From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5939CC47258 for ; Wed, 24 Jan 2024 02:05:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hFM3A5wdfalwDIuvbgvDQpirBIvU/6tTYfF061b1NdM=; b=fyct4YKkZrKvkSIax1R2tR6sc6 XA7+AmiarA1Hf7xMYp6DQBqACAN7K+aUJEJuDUP3daPPx/V5bAT2stL9iiWobZgmnP2PJUb/ZC7Pi XgJSP7KuteL9tb8gpHOBGoLMF9jEh39yQ7PFNPS7Mxo81EBVBT8flP3JczQs3RHhM52XqvEBT+s1s 9/sSOnNoF+ywL/CS/bIhZpKt1aWHsbJFwnNHHet28UPGsJH1RPE3xH90cgYoXFgxGE+8lGHE1zmZq PDFW6ceR9CWSa0AsYzTlG5+3YVesd9JMj9cdfkdwJ4Qd21aioRdZ0d1UHG5fIcfH9YXGzvHEd25O8 oDEb6xDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSSdw-0014yB-0E; Wed, 24 Jan 2024 02:05:32 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSSdt-0014wO-03 for ath11k@lists.infradead.org; Wed, 24 Jan 2024 02:05:30 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40O1MLlK027786; Wed, 24 Jan 2024 02:05:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=hFM3A5wdfalwDIuvbgvDQpirBIvU/6tTYfF061b1NdM=; b=b9 je8fhGo8krWu9SrSOKKIkXJ9hR8RO7mzeADUCzEL4ULmjvyvkWt9OyZMmYXOdUiR ZAPMjz18KI66v4QIeFwot+j7xtDsmZd4BakL9QvQqslKLhsIVB4EoHhjl3K2XZ4w py6vAcQuj/iVdyhgOUxPoi4oxmmWT/BCi+8jjCoHjpJM1KjfsD32WIn3vEAXxU07 PCOQxzHxgre3cHZb4dZmBhUNuIvVwD+DkmHTraFdaFvnSd+lQk3N7F7FG0IYX40l NH+p8ltrJgidKKGffkbbNmEKbL2sKaXMQ9ez0MlL61EUV7hjOcDmnxDGtXZxqqh8 uoK87UBhfQ6/rJkH0niA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vtmmeggq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jan 2024 02:05:25 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40O25OjX015018 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Jan 2024 02:05:24 GMT Received: from [10.110.18.75] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 23 Jan 2024 18:05:24 -0800 Message-ID: Date: Tue, 23 Jan 2024 18:05:23 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] wifi: ath11k: remove invalid peer create logic Content-Language: en-US To: Baochen Qiang , CC: References: <20240123025700.2929-1-quic_bqiang@quicinc.com> <20240123025700.2929-2-quic_bqiang@quicinc.com> From: Jeff Johnson In-Reply-To: <20240123025700.2929-2-quic_bqiang@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Bc7B1m2UTwaAegkYv9IgBIer6ptsGMZ2 X-Proofpoint-ORIG-GUID: Bc7B1m2UTwaAegkYv9IgBIer6ptsGMZ2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-23_15,2024-01-23_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 mlxlogscore=880 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401240014 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240123_180529_375281_236329FE X-CRM114-Status: GOOD ( 10.87 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 1/22/2024 6:56 PM, Baochen Qiang wrote: > In ath11k_mac_op_assign_vif_chanctx(), there is a logic to > create peer using ar->mac_addr for a STA vdev. This is invalid > because a STA vdev should have a peer created using AP's > MAC address. Besides, if we run into that logic, it means a peer > has already been created earlier, we should not create it again. > So remove it. > > This is found during code review. > > Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Baochen Qiang > --- > drivers/net/wireless/ath/ath11k/mac.c | 16 ---------------- My Qualcomm Innovation Center copyright checker reports: drivers/net/wireless/ath/ath11k/mac.c copyright missing 2024 Kalle can fix this in the pending branch Actual code change LGTM so Acked-by: Jeff Johnson