From: Johannes Berg <johannes@sipsolutions.net>
To: John Crispin <john@phrozen.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH v2 1/7] mac80211: add a struct for holding BSS color settings
Date: Mon, 16 Dec 2019 10:49:42 +0100 [thread overview]
Message-ID: <c4b44147e00a8c86931f680d8ea4825cebb4a524.camel@sipsolutions.net> (raw)
In-Reply-To: <20191213155802.25491-1-john@phrozen.org>
On Fri, 2019-12-13 at 16:57 +0100, John Crispin wrote:
> Right now we only track the actual color but not the other bits contained
> within the he_oper field. Fix this by creating a new struct to hold all
> of the info.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
> include/net/cfg80211.h | 15 +++++++++++++++
> include/net/mac80211.h | 2 ++
> 2 files changed, 17 insertions(+)
I think you should drop this patch and put the cfg80211 and mac80211
update into the second and third patch of this series, respectively. It
doesn't make much sense to add some unused structs.
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 8140c4837122..e395ef48af83 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -259,6 +259,19 @@ struct ieee80211_he_obss_pd {
It looks like I didn't see that previously for that one,
> + * struct ieee80211_he_bss_color - AP settings for BSS coloring
but I'd kinda prefer this be called cfg80211_... since it's not part of
ieee80211.h with all the over-the-air struct definitions. I'm sure we
have some non-over-the-air things that are called ieee80211_*, but ...
johannes
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2019-12-16 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:57 [PATCH v2 1/7] mac80211: add a struct for holding BSS color settings John Crispin
2019-12-13 15:57 ` [PATCH v2 2/7] nl80211: add handling for BSS color John Crispin
2019-12-16 9:56 ` Johannes Berg
2019-12-16 15:52 ` John Crispin
2019-12-13 15:57 ` [PATCH v2 3/7] mac80211: " John Crispin
2019-12-13 15:57 ` [PATCH v2 4/7] iwlwifi: use new bss_color struct John Crispin
2019-12-13 15:58 ` [PATCH v2 5/7] mac80211: drop now unused bss_color element John Crispin
2019-12-16 9:57 ` Johannes Berg
2019-12-13 15:58 ` [PATCH v2 6/7] ath11k: add WMI calls required for handling BSS color John Crispin
2019-12-13 15:58 ` [PATCH v2 7/7] ath11k: add handling for " John Crispin
2019-12-16 9:49 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b44147e00a8c86931f680d8ea4825cebb4a524.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox