From: Johannes Berg <johannes@sipsolutions.net>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH V5 3/5] nl80211: add support for BSS coloring
Date: Thu, 27 Aug 2020 14:24:45 +0200 [thread overview]
Message-ID: <c5b79f189345b0fccbe797a8ed158dcae30fdd10.camel@sipsolutions.net> (raw)
In-Reply-To: <20200826055650.1101224-3-john@phrozen.org> (sfid-20200826_075709_238174_DD905459)
> + if (info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]) {
> + params.counter_offset_presp =
> + nla_get_u16(info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]);
You need to check the attribute size here, apparently only exactly a
single counter is supported.
I'm not really sure *why* though - wouldn't be that much more difficult
to add support for an arbitrary number in mac80211?
Either way this is missing a check.
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-08-27 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 5:56 [PATCH V5 1/5] nl80211: rename csa counter attributes countdown counters John Crispin
2020-08-26 5:56 ` [PATCH V5 2/5] mac80211: rename csa counters to " John Crispin
2020-08-27 12:23 ` Johannes Berg
2020-08-26 5:56 ` [PATCH V5 3/5] nl80211: add support for BSS coloring John Crispin
2020-08-27 12:24 ` Johannes Berg [this message]
2020-08-26 5:56 ` [PATCH V5 4/5] mac80211: " John Crispin
2020-08-27 12:26 ` Johannes Berg
2020-08-27 12:29 ` Johannes Berg
2020-08-26 5:56 ` [PATCH V5 5/5] ath11k: " John Crispin
2020-09-08 6:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b79f189345b0fccbe797a8ed158dcae30fdd10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox