From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven@narfation.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Maharaja Kennadyrajan <mkenna@codeaurora.org>
Subject: Re: [PATCH 1/3] nl80211: Add support for beacon tx mode
Date: Thu, 08 Apr 2021 13:11:34 +0200 [thread overview]
Message-ID: <cb0a3bac83f4e56c7b1c0b049080d4f4186bed72.camel@sipsolutions.net> (raw)
In-Reply-To: <2718995.X0rUDs3ZmB@ripper> (sfid-20210222_113458_463202_DAC50CAC)
On Mon, 2021-02-22 at 11:32 +0100, Sven Eckelmann wrote:
> On Monday, 22 February 2021 11:09:31 CET Maharaja Kennadyrajan wrote:
> > User can configure the beacon tx mode while bring-up the AP
> > or MESH. Hence, added the support in the nl80211/cfg80211
> > layer to honour the beacon tx mode configuration and pass
> > this value to the driver.
>
> There is not a definition what this actually means. But I am guessing that you
> are mean the way the HW sends our the beacons for a multivif (beaconing)
> setup. And in this case, it is a per "phy" setting and not a per AP/meshpoint
> setting, right?
In addition, the commit logs are not explaining anything, why you'd use
it, why it's necessary, etc.
I'll say it again: @codeaurora folks, consider the community, not just
your own driver. I'm really getting tired of having to extract
information from you.
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-04-08 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:09 [PATCH 0/3] Add support to configure beacon tx mode Maharaja Kennadyrajan
2021-02-22 10:09 ` [PATCH 1/3] nl80211: Add support for " Maharaja Kennadyrajan
2021-02-22 10:32 ` Sven Eckelmann
2021-04-08 11:11 ` Johannes Berg [this message]
2021-02-22 10:09 ` [PATCH 2/3] mac80211: " Maharaja Kennadyrajan
2021-02-22 10:09 ` [PATCH 3/3] ath11k: " Maharaja Kennadyrajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0a3bac83f4e56c7b1c0b049080d4f4186bed72.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkenna@codeaurora.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox