ATH11K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Baochen Qiang <quic_bqiang@quicinc.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
	Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
	Johan Hovold <johan+linaro@kernel.org>
Subject: Re: [PATCH ath-next v3 5/6] wifi: ath11k: choose default PM policy for hibernation
Date: Tue, 17 Jun 2025 17:37:50 -0700	[thread overview]
Message-ID: <cbd285e8-9ee2-4825-a0b6-da64fbd6b71e@oss.qualcomm.com> (raw)
In-Reply-To: <d0cd065c-1cd1-4e56-8c57-60777b1f3664@oss.qualcomm.com>

On 6/17/2025 5:15 PM, Konrad Dybcio wrote:
> On 3/28/25 6:32 AM, Baochen Qiang wrote:
>> Now WoWLAN mode is chosen for those machines listed in the quirk table.
>> This works for suspend (S3) but breaks for hibernation (S4), because
>> WoWLAN mode requires WLAN power to be sustained, which is not the case
>> during hibernation. For hibernation, the default mode should be used.
>>
>> Register a PM notifier with which kernel can notify us of the actual PM
>> operation: if system is going to suspend, the original PM policy is
>> honored; while if it is hibernation, overwrite it with default policy.
>>
>> To summarize: for suspend (S3), WoWLAN mode is chosen for machines listed
>> in the quirk table, non-WoWLAN mode for others; for hibernation (S4),
>> non-WoWLAN mode is chosen for all.
>>
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>>
>> Tested-by: Takashi Iwai <tiwai@suse.de>
>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
>> ---
> 
> I've bisected the following splat to this patch, still happening on
> linux-next/master, WCN6855 + SC8280XP CRD, 100% reproducibility 

This smells a lot like the issue recently fixed in ath12k:
https://msgid.link/20250604055250.1228501-1-miaoqing.pan@oss.qualcomm.com

Baochen, can you look at the applicability of that patch?

/jeff


  reply	other threads:[~2025-06-18  0:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28  5:32 [PATCH ath-next v3 0/6] wifi: ath11k: bring hibernation support back Baochen Qiang
2025-03-28  5:32 ` [PATCH ath-next v3 1/6] wifi: ath11k: determine PM policy based on machine model Baochen Qiang
2025-03-28  5:32 ` [PATCH ath-next v3 2/6] wifi: ath11k: introduce ath11k_core_continue_suspend_resume() Baochen Qiang
2025-03-28  5:32 ` [PATCH ath-next v3 3/6] wifi: ath11k: refactor ath11k_core_suspend/_resume() Baochen Qiang
2025-03-28  5:32 ` [PATCH ath-next v3 4/6] wifi: ath11k: support non-WoWLAN mode suspend as well Baochen Qiang
2025-03-28  5:32 ` [PATCH ath-next v3 5/6] wifi: ath11k: choose default PM policy for hibernation Baochen Qiang
2025-06-18  0:15   ` Konrad Dybcio
2025-06-18  0:37     ` Jeff Johnson [this message]
2025-06-18  2:00     ` Baochen Qiang
2025-06-23 11:30       ` Konrad Dybcio
2025-06-24  2:11         ` Baochen Qiang
2025-06-24  8:29           ` Johan Hovold
2025-06-18  8:52     ` Johan Hovold
2025-06-18  8:57       ` Johan Hovold
2025-06-18  9:18       ` Konrad Dybcio
2025-06-18  9:44         ` Johan Hovold
2025-03-28  5:32 ` [PATCH ath-next v3 6/6] Reapply "wifi: ath11k: restore country code during resume" Baochen Qiang
2025-03-31 21:46 ` [PATCH ath-next v3 0/6] wifi: ath11k: bring hibernation support back Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbd285e8-9ee2-4825-a0b6-da64fbd6b71e@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=ath11k@lists.infradead.org \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox