From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH 1/3] ath11k: enable mesh mode
Date: Wed, 17 Apr 2019 14:01:22 -0700 [thread overview]
Message-ID: <e1ce8ea8a82f145b5e405b69e83b6a13@codeaurora.org> (raw)
In-Reply-To: <17ff1868-7c2b-efa2-2be3-8f8a504dfd62@phrozen.org>
On 2019-04-17 02:56, John Crispin wrote:
> On 17/04/2019 11:29, Rajkumar Manoharan wrote:
>
>> @@ -3436,6 +3438,8 @@ static int ath11k_add_interface(struct
>> ieee80211_hw *hw,
>> case NL80211_IFTYPE_STATION:
>> arvif->vdev_type = WMI_VDEV_TYPE_STA;
>> break;
>> + case NL80211_IFTYPE_MESH_POINT:
>> + arvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S;
>
> there should be a comment here that the drop is intentional
>
Hmm.. Agree to have fall through comment.
-Rajkumar
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2019-04-17 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:29 [PATCH 0/3] ath11k: Add Mesh mode support Rajkumar Manoharan
2019-04-17 9:29 ` [PATCH 1/3] ath11k: enable mesh mode Rajkumar Manoharan
2019-04-17 9:56 ` John Crispin
2019-04-17 21:01 ` Rajkumar Manoharan [this message]
2019-04-17 9:29 ` [PATCH 2/3] ath11k: allow 4 address transmission for mesh packet Rajkumar Manoharan
2019-04-17 9:57 ` John Crispin
2019-04-17 21:08 ` Rajkumar Manoharan
2019-04-17 9:29 ` [PATCH 3/3] ath11k: remove unnecessary check for PMF Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ce8ea8a82f145b5e405b69e83b6a13@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox