From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
Luciano Coelho <luciano.coelho@intel.com>,
linux-wireless@vger.kernel.org
Cc: michal.kazior@tieto.com, sw@simonwunderlich.de,
andrei.otcheretianski@intel.com, eliad@wizery.com,
ath11k@lists.infradead.org
Subject: Re: [PATCH v10 3/5] cfg80211/mac80211: move interface counting for combination check to mac80211
Date: Tue, 14 Feb 2023 15:41:16 +0100 [thread overview]
Message-ID: <f5ffcc0b186cf9285e1dedebc8cf47c06d46bbd9.camel@sipsolutions.net> (raw)
In-Reply-To: <6c2b5e49-2cdc-b506-e3c8-0a51fccc294d@quicinc.com>
On Tue, 2023-01-10 at 15:23 +0800, Wen Gong wrote:
> On 1/9/2023 6:05 PM, Johannes Berg wrote:
> > On Mon, 2023-01-09 at 17:39 +0800, Wen Gong wrote:
> > > On 3/11/2014 10:16 PM, Luciano Coelho wrote:
> > > > ...
> > > > +int ieee80211_check_combinations(struct ieee80211_sub_if_data *sdata,
> > > > + const struct cfg80211_chan_def *chandef,
> > > > + enum ieee80211_chanctx_mode chanmode,
> > > > + u8 radar_detect)
> ...
> > > > +
> > > > + if (total == 1 && !radar_detect)
> > > > + return 0;
> > > > +
> > > should also check with cfg80211_check_combinations() when total == 1 and
> > > num_different_channels > 1 ?
> > >
> > > When MLO is enabled, it could have 2 channels for one ieee80211_sub_if_data.
> > >
> > Heh. You're commenting on a patch from 2014, well before MLO :-)
> >
> > Not sure what happens in the code now?
> >
> > johannes
> Yes, it is 2014. Each interface only has one channel at 2014.
> I did not hit issue for the code.
>
> the story is like this:
> When station interface and p2p device interface both running.
> the station connect to MLO AP which has 2 links.
> The ieee80211_link_use_channel()/ieee80211_check_combinations() call
> cfg80211_check_combinations()
> for the channel1 and channel2 because total==2.
> When only station interface is running, not called for channel1/channel2
> because total==1.
> That is the little thing I hit.
>
So ... I guess you found a bug? Not sure what I'm supposed to say here.
Send a fix?
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2023-02-14 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1394547394-3910-1-git-send-email-luciano.coelho@intel.com>
[not found] ` <1394547394-3910-4-git-send-email-luciano.coelho@intel.com>
2023-01-09 9:39 ` [PATCH v10 3/5] cfg80211/mac80211: move interface counting for combination check to mac80211 Wen Gong
2023-01-09 10:05 ` Johannes Berg
2023-01-10 7:23 ` Wen Gong
2023-02-14 14:41 ` Johannes Berg [this message]
2023-02-15 1:56 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ffcc0b186cf9285e1dedebc8cf47c06d46bbd9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.otcheretianski@intel.com \
--cc=ath11k@lists.infradead.org \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=michal.kazior@tieto.com \
--cc=quic_wgong@quicinc.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox