From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67B42C5478C for ; Tue, 27 Feb 2024 15:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Kmt/HFUBeRZmflLvOQutfVSNFYpEsx/c0puFabwAwc=; b=O+hgSDWsOuipOp4+WIuFMZJNcY izeFZpe824mEcQQQRI6w8urjbEQIum57P5b+M7WrtDBARdqL9AmOKbo+HF8FXZNTedEf/f4siQboM 7wPIrs3cqII3o4F5+D6zkfo0Gi8+mw/NpNT8AR1X7b1U4sraf7XpLK27jrI8aDjDTUBXUomU/7lpS 9RJeRhnANPMAIDGazfJ/WCfwwFPvqsL0caiWtNvA17ctnuaed3gQHNTp2si2aaRPbgfPyB8ygil53 FO5PqD/d6hwEc44pIHYKOujtkAntXa4fF9gSKUdtmhP0FpaqMGbm+TcxFPeuca44thx9FpVBbHQ7P W4tnwCfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rez7d-00000005jKz-0Kgi; Tue, 27 Feb 2024 15:11:57 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rez7X-00000005jGR-2kXE for ath11k@lists.infradead.org; Tue, 27 Feb 2024 15:11:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=/Kmt/HFUBeRZmflLvOQutfVSNFYpEsx/c0puFabwAwc=; t=1709046708; x=1710256308; b=le6QiN0/vYGUrnNZKEw1HeJfNtv07YEVqs2KBdVNP0fNC5D WlHXkpSsk/UK7PScJ7j65H/rLMOpt5s81+2c4BKZj3n2/RQOlMMzPtpFbe1sq8xmf/IRQ3OjX4vmj hZmGdc1PSEk7fmxQPjsPXgo6YFhkkzkvjfOpZTYX0+Ba3pKaSXTA2BuBT0fIv8mSHxpTuO+zQ4cxr HfP4wlh7/dqj6ybKYVk4oyNM1/QMdorrIhtj+W/4sCTZHDaJebXOwBjuXw43HHSvNkbIkgA/jwi2e CJKZfuLfbshvW8vHRdTQoWIFPk+yEzTtRO+PsHuzVuV/9s4+avpdZ16/u1DJuejQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1rez7Q-0000000Al16-0b6K; Tue, 27 Feb 2024 16:11:44 +0100 Message-ID: Subject: Re: [PATCH 2/6] wifi: ath11k: add P2P IE in beacon template From: Johannes Berg To: Jeff Johnson , Kang Yang , ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Tue, 27 Feb 2024 16:11:43 +0100 In-Reply-To: <3582b1ea-e103-4b7f-b34e-6457964bdb93@quicinc.com> References: <20240226060203.2040444-1-quic_kangyang@quicinc.com> <20240226060203.2040444-3-quic_kangyang@quicinc.com> <42652a06-33f3-445a-bd8a-da4633fa52f8@quicinc.com> <5c5ad99d3c2f3b9915b440057eab6618639cd31f.camel@sipsolutions.net> <3582b1ea-e103-4b7f-b34e-6457964bdb93@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_071151_715804_5338F36E X-CRM114-Status: UNSURE ( 8.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On Tue, 2024-02-27 at 07:05 -0800, Jeff Johnson wrote: > On 2/26/2024 11:32 PM, Johannes Berg wrote: > > @Jeff: NL80211_IFTYPE_P2P_GO is not used by mac80211 internally, it > > translates that to vif->type=3D=3DNL80211_IFTYPE_AP && vif->p2p=3D=3Dtr= ue. >=20 > Yesterday I was looking at another patch and while doing so noticed this > as well. Too many years of working with our downstream Android driver > where we use the P2P iftypes directly... I do sometimes wonder if this was the right decision ... but I think it'll be quite difficult to change it now. johannes