From: Krzysztof Kozlowski <krzk@kernel.org>
To: Miaoqing Pan <quic_miaoqing@quicinc.com>, kvalo@kernel.org
Cc: quic_jjohnson@quicinc.com, ath11k@lists.infradead.org,
linux-wireless@vger.kernel.org, dmitry.baryshkov@linaro.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath11k-pci: add firmware-name property
Date: Thu, 24 Oct 2024 08:43:29 +0200 [thread overview]
Message-ID: <fd98c29c-d7f0-4ddf-b7d9-e4904b43e1bd@kernel.org> (raw)
In-Reply-To: <20241024002514.92290-2-quic_miaoqing@quicinc.com>
On 24/10/2024 02:25, Miaoqing Pan wrote:
> This is the same optional property that defined in qcom,ath10k.yaml. It's
> useful for the platform / board to specify firmware through device-tree.
Wasn't this rejected already?
Anyway NAK for the reasons below.
>
> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-24 6:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 0:25 [PATCH v2 0/2] wifi: ath11k: support board-specific firmware overrides Miaoqing Pan
2024-10-24 0:25 ` [PATCH v2 1/2] dt-bindings: net: wireless: ath11k-pci: add firmware-name property Miaoqing Pan
2024-10-24 6:43 ` Krzysztof Kozlowski [this message]
2024-10-24 0:25 ` [PATCH v2 2/2] wifi: ath11k: support board-specific firmware overrides Miaoqing Pan
2024-10-24 19:39 ` Dmitry Baryshkov
2024-10-25 2:56 ` Miaoqing Pan
2024-10-25 6:01 ` Dmitry Baryshkov
2024-10-25 7:22 ` Miaoqing Pan
2024-10-25 10:20 ` Dmitry Baryshkov
2024-10-25 12:03 ` Miaoqing Pan
2024-10-25 12:21 ` Dmitry Baryshkov
2024-10-25 13:43 ` Miaoqing Pan
2024-10-25 14:01 ` Dmitry Baryshkov
2024-10-25 14:23 ` Miaoqing Pan
2024-10-25 15:27 ` Dmitry Baryshkov
2024-10-26 2:31 ` Miaoqing Pan
2024-10-28 10:32 ` Miaoqing Pan
2024-10-28 13:45 ` Dmitry Baryshkov
2024-11-01 1:32 ` Miaoqing Pan
2024-11-07 17:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd98c29c-d7f0-4ddf-b7d9-e4904b43e1bd@kernel.org \
--to=krzk@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_miaoqing@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox