From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F30FCA0EFA for ; Tue, 26 Aug 2025 15:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SwQL66e3Nu9k+2rWN9KxTqPiCmr+WouftcMZ22iOrnk=; b=HNrdiP5IqjOcUhV2M+x0sU5Wm1 ScRz66bou+a28zxekVSP8AE7nmJzm7jaid5o0XXAB1uDq7h9DlMgeIJV6YtYco0yQ1mhKXRWsOI3U k+0GnjqARbGnzngnX2Db50GFzsC1uZDIzmP390N+BUoE/8FpZ3VgNe24IawvK65/70Rzt8mqMXpXF tvD/OP0sSQROP/+0sf0Bu/d8UtDkyxhB7An8ZHYFk8PEzSCZoHyk5hyxH7KQUJTf6biVCPTjiNx5b AS1fL1mq7VCOWw2lnUa0hi2u3Lv+VxJ8KMLePXwW1eqAKGKPSO+6xI0pwEBQ4crnclYGForP50rnr AycTp7Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqvSC-0000000CQYe-3DRZ; Tue, 26 Aug 2025 15:19:20 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqvS8-0000000CQWY-32L9 for ath12k@lists.infradead.org; Tue, 26 Aug 2025 15:19:19 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57Q9VE9H021344 for ; Tue, 26 Aug 2025 15:19:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SwQL66e3Nu9k+2rWN9KxTqPiCmr+WouftcMZ22iOrnk=; b=eIgUxzswlkZHaCJj rnGJn/nm+urEM+YqiKmfCGzN9GianKouzNyZ4SMpX/5oHoXQBdOD92gtcvaJyGHJ HYcIwvtBb3wL+6ClPuis+8ZugT820zeUWhxaAf/J8MFqajlb0f8yyom/5qH5LcMG MPAUcLqG5oXx2rNdeim+dtqRMpnKQN3VNzUkXKaqRqHcyyoEQYQ32v2vAd5GIvcj I/rZmy9gjqo6fhYhEZZ7aPePWpgmlf8i9yjFrk4UWnkuiUfZKWJqX5k3ICVl6duZ fkRGBAvgp9w8u/ByXFJ3YR7qq/jxHiPjhtl5ldeR9VJji7FtqxQDrB7rFCfZIW9A ZrE4EQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48q615h7u0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Aug 2025 15:19:14 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-324e4c3af5fso5879984a91.3 for ; Tue, 26 Aug 2025 08:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756221553; x=1756826353; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SwQL66e3Nu9k+2rWN9KxTqPiCmr+WouftcMZ22iOrnk=; b=PI05K64s1QT1ApIgiXWFWmKVrJUmxvLNT+R1+qdnqyretl4auCzcDSbsM3Asd3443J u22sGUiF0AiSkn6gZ6FPaq3+uumDk8JUBTAm0cxnX0WbQan5LIqiuQMaNayEYZ/MkO3q wQArWMeIRtok0im4H1e4glQzLerEz5wCDwz57JXie3fnV2I3xn4ZWQZxXkgLdz3dHMoR s4j28PbFl5bSqMScsX6ymawF++NdmPl1Tfi6ZBxPHEpIA3D9zH1ZBntjamtyfDZxc+zm e1n9Ik1PpQlHY7SjewgYL7jK1XfhkxLB25AEkFbqo0MGBebL528xw/GoJCNbjoINnaCH fjjA== X-Forwarded-Encrypted: i=1; AJvYcCVR8B2LLVVvGyjio+1JJ8EiKyDeWvUpt1Lsik3nWRr1IGoqFIYCGrYQO5wI7jM1CBVLJL3jhiI=@lists.infradead.org X-Gm-Message-State: AOJu0Yw+3TaT04PDwCPaT51JILkix748Yz9DY7PpS1mYGWgf/VvJv33r uclve8xf8XzMRoUx7BKjOCSLzvGZcPvznLTEodweB2HOZAUub/+dzNueUmps9upKmeATJJa9z3W 5laBIXwAzsa6zavH4utYS9QRQkzISCvSwEbRGEtRgwc2e0HRVw1h4XExfXn8F63bq X-Gm-Gg: ASbGncvt35h9NMwHFdYMCDayG9wZ/Pl4qzjbb0KW7cXE/EhfwIWMyB470VkYQqXYTbj l7zIYNkbm2cnM2qRnH4zZgZdOBJg9weKHUR0wGefqOnFj1HG+f4ZEMR8wzq18e1p9h1M5lGc8GV 2gg1HIJ4QysQaSXwrpCB2Q+lugxuQI2pkZYf1HPrku79zE/TEWdrEyse4KWGvn4ARdjBt9puGQB LeLyHptuOVcX9/LAGhI0ukiyOjO73go2H4cqi3XM1prfnQqYy0zUuIaj9UWO8aDwX+U8RGa/jBX Dcl+hixPu68oTYm9LFv6NqeUCpvUxD4Fsbk97zy2lMahUIkUOmKMw7Kctw+wBBWrvjv7w4yUQX8 bIdgh0/2x/2jnMXTok6k= X-Received: by 2002:a17:90b:39cf:b0:325:17e1:ab69 with SMTP id 98e67ed59e1d1-32517e1b5a7mr19762800a91.3.1756221553061; Tue, 26 Aug 2025 08:19:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBFCqB9ocm/fFjwbsOzFsZHFiZH3GbPHYwnLpzF4CEcjFDhaSfsGGNUpwdAdtaM5f+IRrboQ== X-Received: by 2002:a17:90b:39cf:b0:325:17e1:ab69 with SMTP id 98e67ed59e1d1-32517e1b5a7mr19762764a91.3.1756221552537; Tue, 26 Aug 2025 08:19:12 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3254aa708cdsm10154132a91.26.2025.08.26.08.19.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Aug 2025 08:19:12 -0700 (PDT) Message-ID: <0993bd25-3cab-4f96-9398-bf5b5f7770cd@oss.qualcomm.com> Date: Tue, 26 Aug 2025 08:19:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] PCI/ASPM: Return enabled ASPM states from pcie_aspm_enabled() API To: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Nirmal Patel , Jonathan Derrick , Jeff Johnson Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org, =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Krishna Chaitanya Chundru , "Rafael J. Wysocki" References: <20250825-ath-aspm-fix-v2-0-61b2f2db7d89@oss.qualcomm.com> <20250825-ath-aspm-fix-v2-5-61b2f2db7d89@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250825-ath-aspm-fix-v2-5-61b2f2db7d89@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAzNCBTYWx0ZWRfXzIy/WVruDIIP VLYFqWjb2YVls/xLdGTWXnS6d515X0xGYffZTwcvahzEiKz3ZFr6aU19tpBBFAc17y4y9mh0+WH R8/jZOuFpPcfj4v/ySU6dN41nYWaZoMNyMaUOpIzxcuBliLSkFZmWY2XSQY9FQJDHCAzqd+Btms 3Hhsqe4FWr1JUKGAhF4hPCnCjiAN/U2+dyL8T7Z1kvThmHjOAt7Ys7x+2sJToNrj/V2msbi254o 0wr22uWjf0jD01qBJQMTl6GKvLrNvboL+2YkrEiM0KitQm45pN5XnOTJOq8bGE7lUvOvdVPD/rD f/hKVlKrOIfszYScHZNc+0/7CzXw9YmqpyMrRdYFOik/3xEKaljLIcfditE11dRXdgZWpp6HaWS QtlDwP1X X-Proofpoint-GUID: 4uHI7_0QcB6gXofx7Z58ycnqGeDsjG23 X-Authority-Analysis: v=2.4 cv=K+AiHzWI c=1 sm=1 tr=0 ts=68add072 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=guytT1_IP8q0_Fb2ReoA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: 4uHI7_0QcB6gXofx7Z58ycnqGeDsjG23 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-26_02,2025-08-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508230034 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250826_081916_880585_7A5C0302 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 8/25/2025 10:44 AM, Manivannan Sadhasivam via B4 Relay wrote: > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1851,7 +1851,7 @@ int pci_enable_link_state(struct pci_dev *pdev, int state); > int pci_enable_link_state_locked(struct pci_dev *pdev, int state); > void pcie_no_aspm(void); > bool pcie_aspm_support_enabled(void); > -bool pcie_aspm_enabled(struct pci_dev *pdev); > +u32 pcie_aspm_enabled(struct pci_dev *pdev); > #else > static inline int pci_disable_link_state(struct pci_dev *pdev, int state) > { return 0; } > @@ -1863,7 +1863,7 @@ static inline int pci_enable_link_state_locked(struct pci_dev *pdev, int state) > { return 0; } > static inline void pcie_no_aspm(void) { } > static inline bool pcie_aspm_support_enabled(void) { return false; } > -static inline bool pcie_aspm_enabled(struct pci_dev *pdev) { return false; } > +static inline u32 pcie_aspm_enabled(struct pci_dev *pdev) { return false; } return 0? > #endif > > #ifdef CONFIG_HOTPLUG_PCI >