Re: [PATCH 33/50] wifi: ath12k: add mhi.c

Jeff Johnson
2022-08-19T19:02:26Z

On 8/18/2022 3:25 PM, Jeff Johnson wrote:
> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>> +static struct mhi_event_config ath12k_mhi_events_qcn9274[] = {
>
> seems this should be const
> but for some reason struct mhi_controller_config has:
> struct mhi_event_config *event_cfg;
>
> (not const) so this can't be const :(
>
> perhaps someone can propose a MHI interface change?
> especially since internally to MHI in parse_ev_cfg() we have:
> const struct mhi_event_config *event_cfg;
> [...]
> for (i = 0; i < num; i++) {
> event_cfg = &config->event_cfg[i];
>
> so it is treated as const

I submitted a patch for this

<https://lore.kernel.org/mhi/20220819184245.28035-1-quic_jjohnson@quicinc.com/>