Re: [PATCH 06/50] wifi: ath12k: add core.h

Kalle Valo
2022-10-21T10:58:51Z

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

>> +struct ath12k_skb_cb {
>> + dma_addr_t paddr;
>> + u8 flags;
>> + u32 cipher;
>> + struct ath12k *ar;
>> + struct ieee80211_vif *vif;
>> + dma_addr_t paddr_ext_desc;
>> +} __packed;
>
> Usage of __packed seems incorrect since this is not an ABI buffer, and
> packing will potentially result in some members being unaligned
> (ath11k has struct ath11k_skb_cb packed as well).
>
> Suggest removing __packed and using pahole to find the ideal layout
> since the only concern is that this does not exceed
> IEEE80211_TX_INFO_DRIVER_DATA_SIZE

Praneesh fixed this in ath12k-bringup:

1a458fd07d47 ath12k: remove __packed from the ath12k_skb_cb struct

--