Re: [PATCH 29/50] wifi: ath12k: add hw.c

Jeff Johnson
2022-08-18T21:31:24Z

On 8/12/2022 9:09 AM, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> (Patches split into one patch per file for easier review, but the final
> commit will be one big patch. See the cover letter for more info.)
>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/hw.c | 961 +++++++++++++++++++++++++++++++++++
> 1 file changed, 961 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath12k/hw.c b/drivers/net/wireless/ath/ath12k/hw.c

snip

> +static const struct ath12k_hw_ring_mask ath12k_hw_ring_mask_qcn9274 = {
> + .tx = {
> + ATH12K_TX_RING_MASK_0,
> + ATH12K_TX_RING_MASK_1,
> + ATH12K_TX_RING_MASK_2,
> + ATH12K_TX_RING_MASK_3,
> + },
> + .rx_mon_dest = {
> + 0, 0, 0,
> + ATH12K_RX_MON_RING_MASK_0,
> + ATH12K_RX_MON_RING_MASK_1,
> + ATH12K_RX_MON_RING_MASK_2,
> + },
> + .rx = {
> + 0, 0, 0, 0,
> + ATH12K_RX_RING_MASK_0,
> + ATH12K_RX_RING_MASK_1,
> + ATH12K_RX_RING_MASK_2,
> + ATH12K_RX_RING_MASK_3,
> + },
> + .rx_err = {
> + 0, 0, 0,
> + ATH12K_RX_ERR_RING_MASK_0,
> + },
> + .rx_wbm_rel = {
> + 0, 0, 0,
> + ATH12K_RX_WBM_REL_RING_MASK_0,
> + },
> + .reo_status = {
> + 0, 0, 0,
> + ATH12K_REO_STATUS_RING_MASK_0,
> + },
> + .host2rxdma = {
> + 0, 0, 0,
> + ATH12K_HOST2RXDMA_RING_MASK_0,
> + },
> + .tx_mon_dest = {
> + ATH12K_TX_MON_RING_MASK_0,
> + ATH12K_TX_MON_RING_MASK_1,
> + 0, 0, 0, 0, 0, 0

nit: trailing 0s do not need to be specified
(none of the other initializers have them)

> + },
> +};
> +
> +static const struct ath12k_hw_ring_mask ath12k_hw_ring_mask_wcn7850 = {
> + .tx = {
> + ATH12K_TX_RING_MASK_0,
> + ATH12K_TX_RING_MASK_2,
> + ATH12K_TX_RING_MASK_4,
> + },
> +
> + .rx = {
> + 0, 0, 0,
> + ATH12K_RX_RING_MASK_0,
> + ATH12K_RX_RING_MASK_1,
> + ATH12K_RX_RING_MASK_2,
> + ATH12K_RX_RING_MASK_3,
> + },
> + .rx_err = {
> + ATH12K_RX_ERR_RING_MASK_0,
> + },
> + .rx_wbm_rel = {
> + ATH12K_RX_WBM_REL_RING_MASK_0,
> + },
> + .reo_status = {
> + ATH12K_REO_STATUS_RING_MASK_0,
> + },
> +
> + .host2rxdma = {
> + },

nit: add empty .rx_mon_dest & .tx_mon_dest initializers?

> +};
> +

snip