Re: [PATCH 40/50] wifi: ath12k: add qmi.h

Jeff Johnson
2022-08-19T00:25:50Z

On 8/12/2022 9:09 AM, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
>
> (Patches split into one patch per file for easier review, but the final
> commit will be one big patch. See the cover letter for more info.)
>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/qmi.h | 610 ++++++++++++++++++++++++++++++++++
[...]
> +struct qmi_wlanfw_ce_tgt_pipe_cfg_s_v01 {
> + __le32 pipe_num;
> + __le32 pipe_dir;
> + __le32 nentries;
> + __le32 nbytes_max;
> + __le32 flags;
> +};
> +
> +struct qmi_wlanfw_ce_svc_pipe_cfg_s_v01 {
> + __le32 service_id;
> + __le32 pipe_dir;
> + __le32 pipe_num;
> +};

curious why the above two structs use __le32 definitions but none of the
others do. I thought the QMI interface would use the qmi_elem_info to
properly encode/decode in host order on both sides of the pipe and hence
we should expect host order on both sides