RE: [PATCH 29/50] wifi: ath12k: add hw.c

Karthikeyan Periyasamy (QUIC)
2022-10-04T11:29:09Z

> -----Original Message-----
> From: Jeff Johnson <quic_jjohnson@quicinc.com>
> Sent: Friday, August 19, 2022 3:01 AM
> To: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org
> Cc: ath12k@lists.infradead.org
> Subject: Re: [PATCH 29/50] wifi: ath12k: add hw.c
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> On 8/12/2022 9:09 AM, Kalle Valo wrote:
> > From: Kalle Valo <quic_kvalo@quicinc.com>
> >
> > (Patches split into one patch per file for easier review, but the
> > final commit will be one big patch. See the cover letter for more
> > info.)
> >
> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> > ---
> > drivers/net/wireless/ath/ath12k/hw.c | 961
> +++++++++++++++++++++++++++++++++++
> > 1 file changed, 961 insertions(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath12k/hw.c
> > b/drivers/net/wireless/ath/ath12k/hw.c
>
> snip
>
> > +static const struct ath12k_hw_ring_mask ath12k_hw_ring_mask_qcn9274
> = {
> > + .tx = {
> > + ATH12K_TX_RING_MASK_0,
> > + ATH12K_TX_RING_MASK_1,
> > + ATH12K_TX_RING_MASK_2,
> > + ATH12K_TX_RING_MASK_3,
> > + },
> > + .rx_mon_dest = {
> > + 0, 0, 0,
> > + ATH12K_RX_MON_RING_MASK_0,
> > + ATH12K_RX_MON_RING_MASK_1,
> > + ATH12K_RX_MON_RING_MASK_2,
> > + },
> > + .rx = {
> > + 0, 0, 0, 0,
> > + ATH12K_RX_RING_MASK_0,
> > + ATH12K_RX_RING_MASK_1,
> > + ATH12K_RX_RING_MASK_2,
> > + ATH12K_RX_RING_MASK_3,
> > + },
> > + .rx_err = {
> > + 0, 0, 0,
> > + ATH12K_RX_ERR_RING_MASK_0,
> > + },
> > + .rx_wbm_rel = {
> > + 0, 0, 0,
> > + ATH12K_RX_WBM_REL_RING_MASK_0,
> > + },
> > + .reo_status = {
> > + 0, 0, 0,
> > + ATH12K_REO_STATUS_RING_MASK_0,
> > + },
> > + .host2rxdma = {
> > + 0, 0, 0,
> > + ATH12K_HOST2RXDMA_RING_MASK_0,
> > + },
> > + .tx_mon_dest = {
> > + ATH12K_TX_MON_RING_MASK_0,
> > + ATH12K_TX_MON_RING_MASK_1,
> > + 0, 0, 0, 0, 0, 0
>
> nit: trailing 0s do not need to be specified (none of the other initializers have
> them)
>

Sure will address this comment in the next version of the patch

>
> > + },
> > +};
> > +
> > +static const struct ath12k_hw_ring_mask ath12k_hw_ring_mask_wcn7850
> = {
> > + .tx = {
> > + ATH12K_TX_RING_MASK_0,
> > + ATH12K_TX_RING_MASK_2,
> > + ATH12K_TX_RING_MASK_4,
> > + },
> > +
> > + .rx = {
> > + 0, 0, 0,
> > + ATH12K_RX_RING_MASK_0,
> > + ATH12K_RX_RING_MASK_1,
> > + ATH12K_RX_RING_MASK_2,
> > + ATH12K_RX_RING_MASK_3,
> > + },
> > + .rx_err = {
> > + ATH12K_RX_ERR_RING_MASK_0,
> > + },
> > + .rx_wbm_rel = {
> > + ATH12K_RX_WBM_REL_RING_MASK_0,
> > + },
> > + .reo_status = {
> > + ATH12K_REO_STATUS_RING_MASK_0,
> > + },
> > +
> > + .host2rxdma = {
> > + },
>
> nit: add empty .rx_mon_dest & .tx_mon_dest initializers?

Sure will address this comment in the next version of the patch

>
> > +};
> > +
>
> snip

Thanks
Karthikeyan