Re: [PATCH 36/50] wifi: ath12k: add pci.h

Kalle Valo
2022-11-08T14:56:59Z

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/12/2022 9:09 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> (Patches split into one patch per file for easier review, but the final
>> commit will be one big patch. See the cover letter for more info.)
>>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>> ---
>> drivers/net/wireless/ath/ath12k/pci.h | 132 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 132 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/pci.h
>> b/drivers/net/wireless/ath/ath12k/pci.h
> [...]
>> +struct ath12k_msi_user {
>> + char *name;
>
> should this be const?

Fixed.

>> + int num_vectors;
>> + u32 base_vector;
>> +};
>> +
>> +struct ath12k_msi_config {
>> + int total_vectors;
>> + int total_users;
>> + struct ath12k_msi_user *users;
>
> should this be const?

This is fixed.

> then the following typecast in pci.c would not be necessary:
>
> static const struct ath12k_msi_config ath12k_msi_config[] = {
> {
> [...]
> .users = (struct ath12k_msi_user[]) {
> [...]
> },
> [...]

But I couldn't figure out how to remove the cast, I got compiler errors
whatever I tried. I added to todo and will revisit later.

--