public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 7/9] wifi: ath12k: fix ath12k_qmi_alloc_chunk() to handle too large allocations
Date: Mon,  9 Dec 2024 20:54:19 +0200	[thread overview]
Message-ID: <20241209185421.376381-8-kvalo@kernel.org> (raw)
In-Reply-To: <20241209185421.376381-1-kvalo@kernel.org>

From: Aditya Kumar Singh <quic_adisi@quicinc.com>

If the requested memory chunk is too large, an error message is logged, but the
request continues to be processed. However, no actual memory is allocated to
the firmware from this request. Instead, the firmware sends another request
with smaller chunks, where memory will be allocated accordingly. Therefore, it
is pointless to proceed with parsing the request if at least one of the
requests cannot be fulfilled.

Hence, return -EAGAIN immediately and proceed to process the new request.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/qmi.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
index e7846aaca10a..964d350be748 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.c
+++ b/drivers/net/wireless/ath/ath12k/qmi.c
@@ -2497,7 +2497,7 @@ static int ath12k_qmi_alloc_chunk(struct ath12k_base *ab,
 				    chunk->size,
 				    chunk->type);
 			ath12k_qmi_free_target_mem_chunk(ab);
-			return 0;
+			return -EAGAIN;
 		}
 		ath12k_warn(ab, "memory allocation failure for %u size: %d\n",
 			    chunk->type, chunk->size);
@@ -2600,6 +2600,14 @@ static int ath12k_qmi_alloc_target_mem_chunk(struct ath12k_base *ab)
 
 	mutex_unlock(&ag->mutex);
 
+	/* The firmware will attempt to request memory in smaller chunks
+	 * on the next try. However, the current caller should be notified
+	 * that this instance of request parsing was successful.
+	 * Therefore, return 0 only.
+	 */
+	if (ret == -EAGAIN)
+		ret = 0;
+
 	return ret;
 }
 
-- 
2.39.5



  parent reply	other threads:[~2024-12-09 18:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 18:54 [PATCH 0/9] wifi: ath12k: MLO support part 8 Kalle Valo
2024-12-09 18:54 ` [PATCH 1/9] wifi: ath12k: move to HW link id based reveive handling Kalle Valo
2024-12-09 19:44   ` Jeff Johnson
2024-12-09 20:01     ` Kalle Valo
2024-12-09 18:54 ` [PATCH 2/9] wifi: ath12k: add partner device buffer support in receive data path Kalle Valo
2024-12-09 18:54 ` [PATCH 3/9] wifi: ath12k: add helper function to init partner cmem configuration Kalle Valo
2024-12-09 18:54 ` [PATCH 4/9] wifi: ath12k: introduce interface combination cleanup helper Kalle Valo
2024-12-09 18:54 ` [PATCH 5/9] wifi: ath12k: Refactor radio frequency information Kalle Valo
2024-12-09 18:54 ` [PATCH 6/9] wifi: ath12k: advertise multi device interface combination Kalle Valo
2024-12-09 18:54 ` Kalle Valo [this message]
2024-12-09 18:54 ` [PATCH 8/9] wifi: ath12k: fix ar->supports_6ghz usage during hw register Kalle Valo
2024-12-09 18:54 ` [PATCH 9/9] wifi: ath12k: pass link ID during MLO while delivering skb Kalle Valo
2024-12-10  8:25 ` [PATCH 0/9] wifi: ath12k: MLO support part 8 Kalle Valo
2024-12-16 16:50 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241209185421.376381-8-kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox