From: kernel test robot <lkp@intel.com>
To: Aloka Dixit <quic_alokad@quicinc.com>,
ath11k@lists.infradead.org, ath12k@lists.infradead.org,
linux-wireless@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Aloka Dixit <quic_alokad@quicinc.com>
Subject: Re: [PATCH 1/5] wifi: ath11k: refactor transmitted arvif retrieval
Date: Thu, 16 Jan 2025 07:16:46 +0800 [thread overview]
Message-ID: <202501160626.Jbb3GHnk-lkp@intel.com> (raw)
In-Reply-To: <20250114223612.2979310-2-quic_alokad@quicinc.com>
Hi Aloka,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0c5fcd9069dd5f984e39820629acbfbe0f1b4256]
url: https://github.com/intel-lab-lkp/linux/commits/Aloka-Dixit/wifi-ath11k-refactor-transmitted-arvif-retrieval/20250115-063922
base: 0c5fcd9069dd5f984e39820629acbfbe0f1b4256
patch link: https://lore.kernel.org/r/20250114223612.2979310-2-quic_alokad%40quicinc.com
patch subject: [PATCH 1/5] wifi: ath11k: refactor transmitted arvif retrieval
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250116/202501160626.Jbb3GHnk-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250116/202501160626.Jbb3GHnk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501160626.Jbb3GHnk-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath11k/mac.c:6349:46: warning: variable 'tx_vif' is uninitialized when used here [-Wuninitialized]
6349 | if (ar->hw->wiphy != ieee80211_vif_to_wdev(tx_vif)->wiphy)
| ^~~~~~
drivers/net/wireless/ath/ath11k/mac.c:6339:30: note: initialize the variable 'tx_vif' to silence this warning
6339 | struct ieee80211_vif *tx_vif;
| ^
| = NULL
1 warning generated.
vim +/tx_vif +6349 drivers/net/wireless/ath/ath11k/mac.c
d5c65159f28953 Kalle Valo 2019-11-23 6333
5a81610acf66c4 Aloka Dixit 2023-05-05 6334 static int ath11k_mac_setup_vdev_params_mbssid(struct ath11k_vif *arvif,
5a81610acf66c4 Aloka Dixit 2023-05-05 6335 u32 *flags, u32 *tx_vdev_id)
5a81610acf66c4 Aloka Dixit 2023-05-05 6336 {
5a81610acf66c4 Aloka Dixit 2023-05-05 6337 struct ath11k *ar = arvif->ar;
5a81610acf66c4 Aloka Dixit 2023-05-05 6338 struct ath11k_vif *tx_arvif;
5a81610acf66c4 Aloka Dixit 2023-05-05 6339 struct ieee80211_vif *tx_vif;
5a81610acf66c4 Aloka Dixit 2023-05-05 6340
5a81610acf66c4 Aloka Dixit 2023-05-05 6341 *tx_vdev_id = 0;
72f88bc503a76c Aloka Dixit 2025-01-14 6342 tx_arvif = ath11k_mac_get_tx_arvif(arvif);
72f88bc503a76c Aloka Dixit 2025-01-14 6343 if (!tx_arvif) {
5a81610acf66c4 Aloka Dixit 2023-05-05 6344 *flags = WMI_HOST_VDEV_FLAGS_NON_MBSSID_AP;
5a81610acf66c4 Aloka Dixit 2023-05-05 6345 return 0;
5a81610acf66c4 Aloka Dixit 2023-05-05 6346 }
5a81610acf66c4 Aloka Dixit 2023-05-05 6347
5a81610acf66c4 Aloka Dixit 2023-05-05 6348 if (arvif->vif->bss_conf.nontransmitted) {
5a81610acf66c4 Aloka Dixit 2023-05-05 @6349 if (ar->hw->wiphy != ieee80211_vif_to_wdev(tx_vif)->wiphy)
5a81610acf66c4 Aloka Dixit 2023-05-05 6350 return -EINVAL;
5a81610acf66c4 Aloka Dixit 2023-05-05 6351
5a81610acf66c4 Aloka Dixit 2023-05-05 6352 *flags = WMI_HOST_VDEV_FLAGS_NON_TRANSMIT_AP;
5a81610acf66c4 Aloka Dixit 2023-05-05 6353 *tx_vdev_id = ath11k_vif_to_arvif(tx_vif)->vdev_id;
5a81610acf66c4 Aloka Dixit 2023-05-05 6354 } else if (tx_arvif == arvif) {
5a81610acf66c4 Aloka Dixit 2023-05-05 6355 *flags = WMI_HOST_VDEV_FLAGS_TRANSMIT_AP;
5a81610acf66c4 Aloka Dixit 2023-05-05 6356 } else {
5a81610acf66c4 Aloka Dixit 2023-05-05 6357 return -EINVAL;
5a81610acf66c4 Aloka Dixit 2023-05-05 6358 }
5a81610acf66c4 Aloka Dixit 2023-05-05 6359
5a81610acf66c4 Aloka Dixit 2023-05-05 6360 if (arvif->vif->bss_conf.ema_ap)
5a81610acf66c4 Aloka Dixit 2023-05-05 6361 *flags |= WMI_HOST_VDEV_FLAGS_EMA_MODE;
5a81610acf66c4 Aloka Dixit 2023-05-05 6362
5a81610acf66c4 Aloka Dixit 2023-05-05 6363 return 0;
5a81610acf66c4 Aloka Dixit 2023-05-05 6364 }
5a81610acf66c4 Aloka Dixit 2023-05-05 6365
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-01-15 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 22:36 [PATCH 0/5] wifi:ath11k/ath12k: refactor tx_arvif retrieval Aloka Dixit
2025-01-14 22:36 ` [PATCH 1/5] wifi: ath11k: refactor transmitted arvif retrieval Aloka Dixit
2025-01-15 19:36 ` Sidhanta Sahu
2025-01-18 0:36 ` Aloka Dixit
2025-01-18 0:44 ` Sidhanta Sahu
2025-01-19 4:57 ` Aloka Dixit
2025-01-15 23:16 ` kernel test robot [this message]
2025-01-14 22:36 ` [PATCH 2/5] wifi: ath11k: pass tx arvif for MBSSID and EMA beacon generation Aloka Dixit
2025-01-14 22:36 ` [PATCH 3/5] wifi: ath12k: refactor transmitted arvif retrieval Aloka Dixit
2025-01-14 22:36 ` [PATCH 4/5] wifi: ath12k: pass tx arvif for MBSSID and EMA beacon generation Aloka Dixit
2025-01-14 22:36 ` [PATCH 5/5] wifi: ath12k: pass BSSID index as input for EMA Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501160626.Jbb3GHnk-lkp@intel.com \
--to=lkp@intel.com \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_alokad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox