Re: [PATCH v2 3/5] wifi: mac80211: Set RTS threshold on per-radio basis

kernel test robot
2025-01-25T11:50:59Z

Hi Roopni,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e7ef944b3e2c31b608800925e784f67596375770]

url: https://github.com/intel-lab-lkp/linux/commits/Roopni-Devanathan/wifi-cfg80211-Add-Support-to-Set-RTS-Threshold-for-each-Radio/20250125-012016
base: e7ef944b3e2c31b608800925e784f67596375770
patch link: https://lore.kernel.org/r/20250124171756.3418663-4-quic_rdevanat%40quicinc.com
patch subject: [PATCH v2 3/5] wifi: mac80211: Set RTS threshold on per-radio basis
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250125/202501251909.8i7nEm4H-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250125/202501251909.8i7nEm4H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501251909.8i7nEm4H-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/rsi/rsi_91x_mac80211.c:1211: warning: Function parameter or struct member 'radio_id' not described in 'rsi_mac80211_set_rts_threshold'

vim +1211 drivers/net/wireless/rsi/rsi_91x_mac80211.c

dad0d04fa7ba41 Fariya Fatima 2014-03-16 1200
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1201 /**
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1202 * rsi_mac80211_set_rts_threshold() - This function sets rts threshold value.
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1203 * @hw: Pointer to the ieee80211_hw structure.
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1204 * @value: Rts threshold value.
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1205 *
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1206 * Return: 0 on success.
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1207 */
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1208 static int rsi_mac80211_set_rts_threshold(struct ieee80211_hw *hw,
607be4e860ab07 Roopni Devanathan 2025-01-24 1209 u8 radio_id,
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1210 u32 value)
dad0d04fa7ba41 Fariya Fatima 2014-03-16 @1211 {
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1212 struct rsi_hw *adapter = hw->priv;
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1213 struct rsi_common *common = adapter->priv;
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1214
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1215 mutex_lock(&common->mutex);
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1216 common->rts_threshold = value;
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1217 mutex_unlock(&common->mutex);
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1218
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1219 return 0;
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1220 }
dad0d04fa7ba41 Fariya Fatima 2014-03-16 1221

--
0-DAY CI Kernel Test Service