From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF0F6C3600C for ; Thu, 3 Apr 2025 19:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mSQUUIG1dewC4yP6ZtlESTt/XBYw7yLsIEmz9BpOaYM=; b=sfLk1VzdBTlvkNluiNd0buFcgg tqM+qEwqckPoZn5azh9o2vHsbhgcD7Z89vQtKVaoEIMH5RpIc2Dn02LO4wNkxugl2Qm5EPm6jnNeT RGrcwoNO0CXyHCvkbtiXnBaD/glybVTuRZ69+ZmpNbnYusKdNfqi3U6kGcr3n+c54RQ2riV60QE3k i5OVZzp2Cl27ZRqGvwNRd0NJ2Aybafs4qbjkwbdh75tlTptVlNWvV20Mk0yyPel3MYAfvVuQUFOED Cieckp+0a6sey2OHyivyxaVRBBH0s9JuyLLNetcolrxDkIZbasTN1OVVwXvIXHOZ41WepmM2rNq0S wPmJ649w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0PpY-00000009d7V-1reo for ath12k@archiver.kernel.org; Thu, 03 Apr 2025 19:02:24 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0PpW-00000009d6U-1Vw5 for ath12k@lists.infradead.org; Thu, 03 Apr 2025 19:02:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C96C86113B; Thu, 3 Apr 2025 19:02:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD96C4CEE3; Thu, 3 Apr 2025 19:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743706941; bh=cGbki3ZhuRmPdsNUUjsHP8UWMK4ZVjl1yl5Jv6/Z+jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NQwZFktOMnZHvbNYPIC3Sl1Xh6fn2Zp2bUD65/mxIAdCkGP71zi024maCWl4yMblF //eQIHmmHqROZR1y1UD0WfxrgB5qj0mh7+Zr5laoBsHNLkqltBUDk1Nyn/fi5g1+cS snNr90guYWoOF+jsOR0eW+eYrUqqiEPdW258zZdGIH7gU/Ckfk4xwMzPYrws42ba52 QAucwnOxZo5bkJ8z9/YjtC0OUafMSq32XsNhB0uDzglT4EkgXL/bJwLj+otqIlzv2e bO0td93PYE/gC609pm5HqHL3JOJ93k8CaAIVT4/iGx8h4phh5f01lNVyJlH3uwPJaC 08hIufR3smSpw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: P Praneesh , Jeff Johnson , Sasha Levin , jjohnson@kernel.org, ath12k@lists.infradead.org Subject: [PATCH AUTOSEL 6.14 05/54] wifi: ath12k: Fix invalid entry fetch in ath12k_dp_mon_srng_process Date: Thu, 3 Apr 2025 15:01:20 -0400 Message-Id: <20250403190209.2675485-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403190209.2675485-1-sashal@kernel.org> References: <20250403190209.2675485-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14 Content-Transfer-Encoding: 8bit X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org From: P Praneesh [ Upstream commit 63fdc4509bcf483e79548de6bc08bf3c8e504bb3 ] Currently, ath12k_dp_mon_srng_process uses ath12k_hal_srng_src_get_next_entry to fetch the next entry from the destination ring. This is incorrect because ath12k_hal_srng_src_get_next_entry is intended for source rings, not destination rings. This leads to invalid entry fetches, causing potential data corruption or crashes due to accessing incorrect memory locations. This happens because the source ring and destination ring have different handling mechanisms and using the wrong function results in incorrect pointer arithmetic and ring management. To fix this issue, replace the call to ath12k_hal_srng_src_get_next_entry with ath12k_hal_srng_dst_get_next_entry in ath12k_dp_mon_srng_process. This ensures that the correct function is used for fetching entries from the destination ring, preventing invalid memory accesses. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: P Praneesh Link: https://patch.msgid.link/20241223060132.3506372-7-quic_ppranees@quicinc.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath12k/dp_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c index 5a21961cfd465..252d8e8a2080e 100644 --- a/drivers/net/wireless/ath/ath12k/dp_mon.c +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c @@ -2519,7 +2519,7 @@ int ath12k_dp_mon_rx_process_stats(struct ath12k *ar, int mac_id, dest_idx = 0; move_next: ath12k_dp_mon_buf_replenish(ab, buf_ring, 1); - ath12k_hal_srng_src_get_next_entry(ab, srng); + ath12k_hal_srng_dst_get_next_entry(ab, srng); num_buffs_reaped++; } -- 2.39.5