Re: [PATCH v5 14/16] wifi: ath12k: Switch to generic PAS TZ APIs

Jeff Johnson
2026-05-05T14:27:17Z

On 5/4/2026 6:06 AM, Sumit Garg wrote:
> @@ -485,9 +485,9 @@ static void ath12k_ahb_power_down(struct ath12k_base *ab, bool is_suspend)
> pasid = (u32_encode_bits(ab_ahb->userpd_id, ATH12K_USERPD_ID_MASK)) |
> ATH12K_AHB_UPD_SWID;
> /* Release the firmware */
> - ret = qcom_scm_pas_shutdown(pasid);
> + ret = qcom_pas_shutdown(pasid);
> if (ret)
> - ath12k_err(ab, "scm pas shutdown failed for userPD%d\n",
> + ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n",
> ab_ahb->userpd_id);

at some point the "ret" param was dropped, and this now generates build warnings

> }
> }