mirror of https://lore.kernel.org/ath12k/
 help / color / mirror / Atom feed
From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Ripan Deuri <quic_rdeuri@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath12k-ng v2 0/8] wifi: ath12k: Improve hal APIs usage in rx path
Date: Thu, 11 Sep 2025 09:51:59 +0800	[thread overview]
Message-ID: <2522a3bf-e56f-4fc7-ac42-d0abf9908418@oss.qualcomm.com> (raw)
In-Reply-To: <20250910181414.2062280-1-quic_rdeuri@quicinc.com>



On 9/11/2025 2:14 AM, Ripan Deuri wrote:
> The existing usage of rx_ops to reach the hal_apis at multiple places uses
> function pointer indirections. In order to avoid such multiple function
> pointer indirection, extract the required hal parameters in the rx path
> right at the beginning and store them in a structure which is then
> leveraged by the rest of the rx path.
> 
> Move remaining rx_ops APIs to hal_ops to simplify hal API usage.
> 
> Also, make compact tlvs as default mode and remove the non-compact tlvs
> as they are unused. Since there is no need to maintain multiple versions
> of tlv extraction APIs, move the rx_ops callbacks to hal_ops.
> 
> ----
> Changes in v2:
>      - Update commit messages in patch 1/8 and 7/8
> ----
> 
> Pavankumar Nandeshwar (5):
>   wifi: ath12k: Remove non-compact TLV support from QCN
>   wifi: ath12k: Replace ops with direct calls for rxdma ring mask
>   wifi: ath12k: Move hal_rx_ops callbacks to hal_ops
>   wifi: ath12k: Add new infra for the rx path
>   wifi: ath12k: Change the API prefixes to ath12k_wifi7 in tx/rx
> 
> Ripan Deuri (3):
>   wifi: ath12k: Move the hal APIs to hardware specific files
>   wifi: ath12k: unify HAL ops naming across chips
>   wifi: ath12k: Remove hal_rx_ops and merge into hal_ops
> 
>  drivers/net/wireless/ath/ath12k/Makefile      |    4 +-
>  drivers/net/wireless/ath/ath12k/ahb.c         |    2 +-
>  drivers/net/wireless/ath/ath12k/core.c        |    2 +-
>  drivers/net/wireless/ath/ath12k/core.h        |    2 -
>  drivers/net/wireless/ath/ath12k/dbring.c      |    5 +-
>  drivers/net/wireless/ath/ath12k/dp.c          |   31 +-
>  drivers/net/wireless/ath/ath12k/dp.h          |    1 -
>  drivers/net/wireless/ath/ath12k/dp_mon.c      |   36 +-
>  drivers/net/wireless/ath/ath12k/dp_rx.c       |  128 +-
>  drivers/net/wireless/ath/ath12k/dp_rx.h       |  204 +---
>  drivers/net/wireless/ath/ath12k/hal.c         | 1048 +----------------
>  drivers/net/wireless/ath/ath12k/hal.h         |  106 +-
>  drivers/net/wireless/ath/ath12k/mac.c         |    6 +-
>  drivers/net/wireless/ath/ath12k/pci.c         |    2 +-
>  drivers/net/wireless/ath/ath12k/wifi7/dp.c    |   19 +-
>  drivers/net/wireless/ath/ath12k/wifi7/dp.h    |    5 +-
>  drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c |  501 ++++----
>  drivers/net/wireless/ath/ath12k/wifi7/dp_rx.h |   74 +-
>  drivers/net/wireless/ath/ath12k/wifi7/dp_tx.c |   49 +-
>  drivers/net/wireless/ath/ath12k/wifi7/dp_tx.h |    8 +-
>  .../wireless/ath/ath12k/wifi7/hal_qcn9274.c   |  369 ++++++
>  .../wireless/ath/ath12k/wifi7/hal_qcn9274.h   |   35 +
>  .../net/wireless/ath/ath12k/wifi7/hal_rx.c    |  161 +--
>  .../net/wireless/ath/ath12k/wifi7/hal_rx.h    |   82 +-
>  .../wireless/ath/ath12k/wifi7/hal_rx_desc.h   |    7 -
>  .../net/wireless/ath/ath12k/wifi7/hal_tx.c    |   13 +-
>  .../net/wireless/ath/ath12k/wifi7/hal_tx.h    |   18 +-
>  .../wireless/ath/ath12k/wifi7/hal_wcn7850.c   |  364 ++++++
>  .../wireless/ath/ath12k/wifi7/hal_wcn7850.h   |   32 +
>  drivers/net/wireless/ath/ath12k/wifi7/pci.c   |    2 -
>  30 files changed, 1452 insertions(+), 1864 deletions(-)
>  create mode 100644 drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
>  create mode 100644 drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
>  create mode 100644 drivers/net/wireless/ath/ath12k/wifi7/hal_wcn7850.c
>  create mode 100644 drivers/net/wireless/ath/ath12k/wifi7/hal_wcn7850.h
> 
> 
> base-commit: d637c58a29475d646f8decfbbc1d27fae999a449

Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>



  parent reply	other threads:[~2025-09-11  1:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 18:14 [PATCH ath12k-ng v2 0/8] wifi: ath12k: Improve hal APIs usage in rx path Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 1/8] wifi: ath12k: Remove non-compact TLV support from QCN Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 2/8] wifi: ath12k: Move the hal APIs to hardware specific files Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 3/8] wifi: ath12k: unify HAL ops naming across chips Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 4/8] wifi: ath12k: Replace ops with direct calls for rxdma ring mask Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 5/8] wifi: ath12k: Move hal_rx_ops callbacks to hal_ops Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 6/8] wifi: ath12k: Add new infra for the rx path Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 7/8] wifi: ath12k: Remove hal_rx_ops and merge into hal_ops Ripan Deuri
2025-09-10 18:14 ` [PATCH ath12k-ng v2 8/8] wifi: ath12k: Change the API prefixes to ath12k_wifi7 in tx/rx Ripan Deuri
2025-09-11  1:51 ` Baochen Qiang [this message]
2025-09-11  3:43 ` [PATCH ath12k-ng v2 0/8] wifi: ath12k: Improve hal APIs usage in rx path Vasanthakumar Thiagarajan
2025-09-11 14:30 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2522a3bf-e56f-4fc7-ac42-d0abf9908418@oss.qualcomm.com \
    --to=baochen.qiang@oss.qualcomm.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_rdeuri@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox