From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Ripan Deuri <quic_rdeuri@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath12k-ng v3 6/6] wifi: ath12k: Refactor ath12k_vif structure
Date: Tue, 30 Sep 2025 11:30:39 +0800 [thread overview]
Message-ID: <39facf12-c452-4fa4-9b76-3da6a0ce3230@oss.qualcomm.com> (raw)
In-Reply-To: <20250929115102.512719-7-quic_rdeuri@quicinc.com>
On 9/29/2025 7:51 PM, Ripan Deuri wrote:
> @@ -938,15 +944,19 @@ int ath12k_dp_pdev_alloc(struct ath12k_base *ab)
>
> static void ath12k_dp_update_vdev_search(struct ath12k_link_vif *arvif)
> {
> + u8 link_id = arvif->link_id;
> + struct ath12k_vif *ahvif = arvif->ahvif;
> + struct ath12k_dp_link_vif *dp_link_vif = &ahvif->dp_vif.dp_link_vif[link_id];
nit: consistently use ath12k_dp_vif_to_dp_link_vif()
> +
> switch (arvif->ahvif->vdev_type) {
> case WMI_VDEV_TYPE_STA:
> - arvif->hal_addr_search_flags = HAL_TX_ADDRY_EN;
> - arvif->search_type = HAL_TX_ADDR_SEARCH_INDEX;
> + dp_link_vif->hal_addr_search_flags = HAL_TX_ADDRY_EN;
> + dp_link_vif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
> break;
> case WMI_VDEV_TYPE_AP:
> case WMI_VDEV_TYPE_IBSS:
> - arvif->hal_addr_search_flags = HAL_TX_ADDRX_EN;
> - arvif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
> + dp_link_vif->hal_addr_search_flags = HAL_TX_ADDRX_EN;
> + dp_link_vif->search_type = HAL_TX_ADDR_SEARCH_DEFAULT;
> break;
> case WMI_VDEV_TYPE_MONITOR:
> default:
[...]
> @@ -318,12 +318,14 @@ int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif,
> struct ath12k_wmi_peer_create_arg *arg)
> {
> struct ieee80211_vif *vif = ath12k_ahvif_to_vif(arvif->ahvif);
> + struct ath12k_vif *ahvif = arvif->ahvif;
> struct ath12k_link_sta *arsta;
> u8 link_id = arvif->link_id;
> struct ath12k_peer *peer;
> struct ath12k_sta *ahsta;
> u16 ml_peer_id;
> int ret;
> + struct ath12k_dp_link_vif *dp_link_vif = &ahvif->dp_vif.dp_link_vif[link_id];
same here, use ath12k_dp_vif_to_dp_link_vif()
>
> lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy);
>
next prev parent reply other threads:[~2025-09-30 3:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 11:50 [PATCH ath12k-ng v3 0/6] wifi: ath12k: Modularization of objects for Next Generation Driver Ripan Deuri
2025-09-29 11:50 ` [PATCH ath12k-ng v3 1/6] wifi: ath12k: Convert ath12k_dp member in ath12k_base to pointer Ripan Deuri
2025-09-29 11:50 ` [PATCH ath12k-ng v3 2/6] wifi: ath12k: Support arch-specific DP device allocation Ripan Deuri
2025-09-29 11:50 ` [PATCH ath12k-ng v3 3/6] wifi: ath12k: Rearrange DP fields in ath12k_hw_group struct Ripan Deuri
2025-09-29 11:51 ` [PATCH ath12k-ng v3 4/6] wifi: ath12k: Add framework for hardware specific ieee80211_ops registration Ripan Deuri
2025-09-29 11:51 ` [PATCH ath12k-ng v3 5/6] wifi: ath12k: Add framework for hardware specific DP interrupt handler Ripan Deuri
2025-09-29 11:51 ` [PATCH ath12k-ng v3 6/6] wifi: ath12k: Refactor ath12k_vif structure Ripan Deuri
2025-09-30 3:30 ` Baochen Qiang [this message]
2025-09-30 13:12 ` Ripan Deuri
2025-09-30 3:31 ` [PATCH ath12k-ng v3 0/6] wifi: ath12k: Modularization of objects for Next Generation Driver Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39facf12-c452-4fa4-9b76-3da6a0ce3230@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rdeuri@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox