From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6737FC32771 for ; Fri, 19 Aug 2022 19:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/fU//pUMtOIXaKhgEgpnx1mwGFMbQdebVbxCWmBcFvk=; b=qWQzRjzPbRXiCe dJa6arJ4bMn0FaOViXtvkWKu0tWlw5OhHGkn8c0yEa1jKjaPMM8FB2rpNSThhQHBUx6Vw+V2QiRJJ DwnabxX0u/Tp5ZUiRc9haOgxgVuzbpFSaSlSfqcOgbDs3jaWewj4TXoK5SjEf5Fj8UsL9Q3tfbveB /Jzv5n91yZTlvicbVKjeBcOxwKVkWHIgWOZ0JSaps+UMmPt+DhC7Mg73odfwNtXudvt4Wb/kBWhSl P4JRrS3bsAwQhItMnJxULanHOjyCON+X9KbucH2js0bu5MGn4bGAuhAfFbzwsXCby2r1rpVcAlsLp zQoYtc8Pg8lHeDQbd1kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP7GD-00BOWm-Ps for ath12k@archiver.kernel.org; Fri, 19 Aug 2022 19:02:25 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP7FL-00BO2y-Qm for ath12k@lists.infradead.org; Fri, 19 Aug 2022 19:01:35 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27JIvZwj004273; Fri, 19 Aug 2022 19:01:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=QcSLGs4SuAganUIc0YVw/OiPQWqEBg69UHJVY0f3+0w=; b=EkLJ2d1Bp/3ieh+qmxlgsRqt1g1atXBGOUunFIoaO1/zDcHWLIXlLN0Ji4r2fcd+vXQO C4giXuDPFD6wKRA6clFyiqntF/fWpOk+DJwYYKXMuk5JXZyC1n50U6wWU6PjvCt3fFHN hGrh1vjDiZEz6wu3E/tCPoSeCazySThUwbztly288BwRpNsQjJzIxP6aoizho45lFnaN mtJ8Fjc9hQCJByrvEKreXSj8R1HnQ3ESKbYY/OX4I2Z5N+nILN1jWxBW13DV6N84ch2J sGyphv3gTqELh2bJ4ZyWQ8/J7h2BToZ6F9gpZstOIv8x+NveTQRPRiwGCcWlWlqNlR3N kw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j21v52k0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Aug 2022 19:01:25 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27JIuOgL030297 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Aug 2022 18:56:24 GMT Received: from [10.110.11.6] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 19 Aug 2022 11:56:24 -0700 Message-ID: <3b09b751-54c1-d684-7d5c-8f736cd80707@quicinc.com> Date: Fri, 19 Aug 2022 11:56:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 33/50] wifi: ath12k: add mhi.c Content-Language: en-US From: Jeff Johnson To: Kalle Valo , CC: References: <20220812161003.27279-1-kvalo@kernel.org> <20220812161003.27279-34-kvalo@kernel.org> <05841a52-3d2f-8704-b885-4b02e7a439e0@quicinc.com> In-Reply-To: <05841a52-3d2f-8704-b885-4b02e7a439e0@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: PyGS-C6aGoyKhqcXPrP9cEe_XoQnCK_W X-Proofpoint-GUID: PyGS-C6aGoyKhqcXPrP9cEe_XoQnCK_W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-19_10,2022-08-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 mlxlogscore=923 phishscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208190071 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_120132_066437_47F361A0 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 8/18/2022 3:25 PM, Jeff Johnson wrote: > On 8/12/2022 9:09 AM, Kalle Valo wrote: >> +static struct mhi_event_config ath12k_mhi_events_qcn9274[] = { > > seems this should be const > but for some reason struct mhi_controller_config has: > struct mhi_event_config *event_cfg; > > (not const) so this can't be const :( > > perhaps someone can propose a MHI interface change? > especially since internally to MHI in parse_ev_cfg() we have: > const struct mhi_event_config *event_cfg; > [...] > for (i = 0; i < num; i++) { > event_cfg = &config->event_cfg[i]; > > so it is treated as const I submitted a patch for this -- ath12k mailing list ath12k@lists.infradead.org https://lists.infradead.org/mailman/listinfo/ath12k