Re: [PATCH v9 2/2] dt-bindings: net: wireless: describe the ath12k PCI module

Kalle Valo
2024-06-06T13:34:21Z

Bartosz Golaszewski <brgl@bgdev.pl> writes:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add device-tree bindings for the ATH12K module found in the WCN7850
> package.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../bindings/net/wireless/qcom,ath12k.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> new file mode 100644
> index 000000000000..1b5884015b15
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2024 Linaro Limited
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies ath12k wireless devices (PCIe)
> +
> +maintainers:
> + - Jeff Johnson <quic_jjohnson@quicinc.com>
> + - Kalle Valo <kvalo@kernel.org>
> +
> +description:
> + Qualcomm Technologies IEEE 802.11be PCIe devices.
> +
> +properties:
> + compatible:
> + enum:
> + - pci17cb,1107 # WCN7850
> +
> + reg:
> + maxItems: 1
> +
> + vddaon-supply:
> + description: VDD_AON supply regulator handle
> +
> + vddwlcx-supply:
> + description: VDD_WLCX supply regulator handle
> +
> + vddwlmx-supply:
> + description: VDD_WLMX supply regulator handle
> +
> + vddrfacmn-supply:
> + description: VDD_RFA_CMN supply regulator handle
> +
> + vddrfa0p8-supply:
> + description: VDD_RFA_0P8 supply regulator handle
> +
> + vddrfa1p2-supply:
> + description: VDD_RFA_1P2 supply regulator handle
> +
> + vddrfa1p8-supply:
> + description: VDD_RFA_1P8 supply regulator handle
> +
> + vddpcie0p9-supply:
> + description: VDD_PCIE_0P9 supply regulator handle
> +
> + vddpcie1p8-supply:
> + description: VDD_PCIE_1P8 supply regulator handle
> +
> +required:
> + - compatible
> + - reg
> + - vddaon-supply
> + - vddwlcx-supply
> + - vddwlmx-supply
> + - vddrfacmn-supply
> + - vddrfa0p8-supply
> + - vddrfa1p2-supply
> + - vddrfa1p8-supply
> + - vddpcie0p9-supply
> + - vddpcie1p8-supply

Same comment here. To my understanding there are ath12k PCI devices
which do not need the supplies. But I guess we change this to optional
later?

--