From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A05EC4345F for ; Mon, 29 Apr 2024 04:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=528m1WBys0h/T5fu3za+Edk+b8XQSJAHr/04TXkqC/g=; b=R+OQkho+gFpSP8XOp1qyFb+eRI ZW3aWhU7Fn23psjm0CEUWqFim1+1YEcBTHLsLzqX0zXoKvh43hidl6FQyqpD11iFKJI/LBsKqM5xC +9UEK252CQnLD9zPXdcobERKxjkLAC14NaWwqRBf1Z7feWlp0BDpw2hWIgdDWHI+ROwy8/RBbMbNV 49o7aaX11vVes/dO08NZeCzBZOoTsuyxJC1vLeZjFS2MqW6CxoOeqlHmU1Vp9+ABCFEsInzTwuBXN itQJiiwKZkvS4QNMw6cVUXw8CRctDIeDgdmfWRG+e6cWt8RIX9cs/Vlw/8wfF+N38Ubtbl0K2I7Xg obKof5hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Iad-00000001PYA-3gCQ for ath12k@archiver.kernel.org; Mon, 29 Apr 2024 04:26:07 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1IaY-00000001PWr-1kY4 for ath12k@lists.infradead.org; Mon, 29 Apr 2024 04:26:05 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43T3xNQV018489; Mon, 29 Apr 2024 04:25:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=528m1WBys0h/T5fu3za+Edk+b8XQSJAHr/04TXkqC/g=; b=pH LlooPGMkeUlcC+6QtD3VQpt1BnIudcdo+6mTyBHla/R0O+as8IfJzd/jqrvPEVF+ c553eVmWJbq8BbiHQwJxPKUrrakojMbYNYl1Se5jSF5VOhtyhzRQYBJLBg+3wpfG 92BJQs1/jXjTw21MFLsixv4T0Ei1xmLJC5sMzjVgt+MWJbCiBvlbzQEfwNbDJi0a LxUs2HTQjpXiKhE8hn4O4Rhal8g87hQOod1q/901ftLlies+yUGubp2K1Ml8oEvR QiJ0uwEOF5gUek7zZkFF0LMCGbFRDYh1Fy/UY8pc0kzVoEOnFctlj1l0IcAG33em Q+mNOllLh3P+XtHzCeiQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xrry4jnam-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 04:25:30 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43T4PSQR010445 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Apr 2024 04:25:28 GMT Received: from [10.151.41.48] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 28 Apr 2024 21:25:27 -0700 Message-ID: <4f567b1a-aebc-709c-5303-ecbeb5cebc30@quicinc.com> Date: Mon, 29 Apr 2024 09:54:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCHv2 0/3] wifi: ath12k: Remove unsupported and unused ring configurations Content-Language: en-US To: Vasanthakumar Thiagarajan , CC: References: <20240427162644.2470886-1-quic_tamizhr@quicinc.com> <4cea96f8-399c-0974-4d9c-21bf5eda143f@quicinc.com> From: Tamizh Chelvam Raja In-Reply-To: <4cea96f8-399c-0974-4d9c-21bf5eda143f@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: pVMBjLGJPUUXmAZ0bR6kgFLs-XWnlZic X-Proofpoint-ORIG-GUID: pVMBjLGJPUUXmAZ0bR6kgFLs-XWnlZic X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-29_01,2024-04-26_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=850 suspectscore=0 mlxscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404290027 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240428_212602_828446_C850133C X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 4/28/2024 8:59 AM, Vasanthakumar Thiagarajan wrote: > > > On 4/27/2024 9:56 PM, Tamizh Chelvam Raja wrote: >> Currently in driver doing memory allocation for tx_monitor, >> tcl_cmd_ring and tcl_status ring. Here driver support for >> tx_monitor mode is not there and memory for tcl_cmd and tcl_status >> rings are allocated by firmware and it uses that memory instead of >> host allocated. So avoid these unused ring setup configuration. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Tamizh Chelvam Raja (3): >>    wifi: ath12k: fix calling correct function for rx monitor mode >>    wifi: ath12k: Remove unsupported tx monitor handling >>    wifi: ath12k: Remove unused tcl_*_ring configuration >> >> v2: >>    * Rebased on top of ToT >> >>   drivers/net/wireless/ath/ath12k/dp.c     | 16 ------- >>   drivers/net/wireless/ath/ath12k/dp.h     |  2 - >>   drivers/net/wireless/ath/ath12k/dp_mon.c | 40 +---------------- >>   drivers/net/wireless/ath/ath12k/dp_rx.c  | 56 ------------------------ >>   drivers/net/wireless/ath/ath12k/dp_tx.c  | 44 +------------------ >>   drivers/net/wireless/ath/ath12k/dp_tx.h  |  1 - >>   6 files changed, 2 insertions(+), 157 deletions(-) >> >> > > It nice to see code removal in general :) > But I've also seen some concerns internally around code removal > especially when the code will have to be re-added in future while > properly supporting the feature. I guess the cover letter > may need to clarify those concerns at least for internal review. > This is mainly to avoid unnecessary memory allocation for the unused rings. And this can be added in the future while enabling the feature. > Other than that, the series LGTM > > Vasanth Tamizh