From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCCF6E77197 for ; Thu, 9 Jan 2025 13:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OUn2275MIuUj73ZXyCcTII1OJclVT0oPKmkONPClk38=; b=oXn/wgd6SyAJyt9QEst1U2//q1 8UQ/WnC6V7OxfPaaQw3occLbJPelH7Edjur4mV+ODLay4DFr2lf5KwS+9+LARuLb4+RZj6+pDP/zP yDoEoDbW2dYqekeU6voKHPu/v8nuRJyyXT3qxPRVqsoevtTRjAtsFFDBzFRYDRdMj6LnK+K4x9Zwh i7wuQTcBoc29NBYiZPLyByeVOYw5Q1y+HgmJPH8Ka2qpj1y+cxcTLSqPvFw+p26PIMzBFQ2/csCif vOYcoTm66HsheDuTZCJYFbCtMTeyomkkcs+Q2KnX3Y9RCv74APRaZeNl4nl0W0IALgXwwXxvwpIWX l4aV2XzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVsOS-0000000ByzM-23Ee for ath12k@archiver.kernel.org; Thu, 09 Jan 2025 13:16:12 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tVsM6-0000000ByFy-0ETj for ath12k@lists.infradead.org; Thu, 09 Jan 2025 13:13:47 +0000 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 509CC9Ut003633; Thu, 9 Jan 2025 13:13:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OUn2275MIuUj73ZXyCcTII1OJclVT0oPKmkONPClk38=; b=bba6Dacu6lXIOstp LTYiYx3lM2g2cCH9SUziXP72ow+iYdNdIIs4zCiSo/V1zQp3/4TnH6ACquIiB81g 2BWXCVhbqv4RC0WPocselciGpNbYNxR4oujvXjEmF2XzzayUo/ggz6KQSjQh+bXE 0GubPL+MM2XePZVJwGdkgIVQscNh7kAASaKEmurTCbHZ60UlvieVBXGfkeR5ephi 373kc1KHitIfj2/e5w7rJLVHIdN7NrM1lFA3XtSTQekCVysz30LzN0wcvQ0kAe7X BIL2sUd72cpr8thNNylr2V12bAOp4xXnfmec8GBw25KjIKzpG3ryi5AOz8CSU99z j1rvKg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 442e8cg4gn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jan 2025 13:13:42 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 509DDfBe028019 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 9 Jan 2025 13:13:41 GMT Received: from [10.50.15.45] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 9 Jan 2025 05:13:39 -0800 Message-ID: <5984d78e-71ff-48a6-9bf2-88ecc299bef6@quicinc.com> Date: Thu, 9 Jan 2025 18:43:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/4] wifi: ath12k: Factory test mode support To: Aditya Kumar Singh , , Kalle Valo CC: References: <20240624095305.37189-1-quic_aarasahu@quicinc.com> Content-Language: en-US From: Aaradhana Sahu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: CAhpHClwbeSWqqg94PmKpHUwae6i-HE6 X-Proofpoint-ORIG-GUID: CAhpHClwbeSWqqg94PmKpHUwae6i-HE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501090105 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250109_051346_217963_6AB060DF X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 1/9/2025 10:25 AM, Aditya Kumar Singh wrote: > On 1/9/25 10:13, Aaradhana Sahu wrote: >> >> >> On 6/24/2024 3:23 PM, Aaradhana Sahu wrote: >>> Device is booted in factory test mode for calibration. >>> The commands are sent from userspace application, which >>> is sent to firmware using wmi commands. Firmware sends >>> the response to driver as wmi events and driver sends >>> these events to the application via netlink message. >>> >>> Also added changes related to correct pdev id access for >>> fw test cmd. >>> >>> Aaradhana Sahu (3): >>>    wifi: ath: create common testmode_i.h file for ath drivers >>>    wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode >>>    wifi: ath12k: add factory test mode support >>> >>> Rajat Soni (1): >>>    wifi: ath12k: Fill pdev id for fw test cmd >>> >>> --- >>> v5: >>>    -Updated copyright >>>    -Fixed line length within 90 char >>> v4: >>>    -Rebased on latest ToT >>> v3: >>>    -Rebased on latest ToT >>>    -Updated Tested-on Tag >>>    -Removed second parameter of ath12k_core_start() >>>    -Updated copyright >>> v2: >>>    -Rebased on latest ath ToT >>> --- >>> >>>   drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++-- >>>   drivers/net/wireless/ath/ath12k/Makefile      |   1 + >>>   drivers/net/wireless/ath/ath12k/core.c        |  22 +- >>>   drivers/net/wireless/ath/ath12k/core.h        |  13 + >>>   drivers/net/wireless/ath/ath12k/debug.h       |   1 + >>>   drivers/net/wireless/ath/ath12k/dp.c          |   3 + >>>   drivers/net/wireless/ath/ath12k/mac.c         |  15 +- >>>   drivers/net/wireless/ath/ath12k/pci.c         |   1 + >>>   drivers/net/wireless/ath/ath12k/testmode.c    | 423 ++++++++++++++++++ >>>   drivers/net/wireless/ath/ath12k/testmode.h    |  40 ++ >>>   drivers/net/wireless/ath/ath12k/wmi.c         |  39 +- >>>   drivers/net/wireless/ath/ath12k/wmi.h         |  21 + >>>   .../wireless/ath/{ath11k => }/testmode_i.h    |  54 +-- >>>   13 files changed, 636 insertions(+), 75 deletions(-) >>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c >>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h >>>   rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (50%) >>> >>> >>> base-commit: cac9bfd02678adbcca9a7dce770609b9f7434d37 >> >> Hi Kalle, >> >> Please let me know, if any thing is pending from the developer side, to merge this series into ath.git tree. > > This series does not apply cleanly on latest tip. And base commit is around 6 months old. So may be you would want to rebase and send a new version? > > Applying: wifi: ath: create common testmode_i.h file for ath drivers > Applying: wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode > Applying: wifi: ath12k: add factory test mode support > error: patch failed: drivers/net/wireless/ath/ath12k/Makefile:26 > error: drivers/net/wireless/ath/ath12k/Makefile: patch does not apply > error: patch failed: drivers/net/wireless/ath/ath12k/core.c:42 > error: drivers/net/wireless/ath/ath12k/core.c: patch does not apply > error: patch failed: drivers/net/wireless/ath/ath12k/core.h:209 > error: drivers/net/wireless/ath/ath12k/core.h: patch does not apply > error: patch failed: drivers/net/wireless/ath/ath12k/debug.h:33 > error: drivers/net/wireless/ath/ath12k/debug.h: patch does not apply > error: patch failed: drivers/net/wireless/ath/ath12k/mac.c:13 > error: drivers/net/wireless/ath/ath12k/mac.c: patch does not apply > error: patch failed: drivers/net/wireless/ath/ath12k/wmi.c:7150 > error: drivers/net/wireless/ath/ath12k/wmi.c: patch does not apply > Patch failed at 0003 wifi: ath12k: add factory test mode support > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > And since you'll be submitting in 2025, don't forget to update > copyrights. > > Sure, will address in the next version.