From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: Re: wifi: mac80211: Re: unicast probe response bssid changed by "wifi: mac80211: do link->MLD address translation on RX"
Date: Wed, 19 Oct 2022 11:38:32 +0200 [thread overview]
Message-ID: <5f652efb43226f67e932f5aaf97cd717992bfd81.camel@sipsolutions.net> (raw)
In-Reply-To: <9fe7c0f2-e02f-e87f-dced-90e973c8992f@quicinc.com>
On Wed, 2022-10-19 at 17:35 +0800, Wen Gong wrote:
> On 9/14/2022 11:13 AM, Wen Gong wrote:
> > Hi Johannes,
> >
> > The mac addr of unicast rx packet all changed to the MLD address by
> > below patch.
> > Now the probe presponse which is unicast packet is also changed mac
> > address here.
> > I found bssid which is the MLD address of my test AP in
> > cfg80211_get_bss().
> > For example, if the AP has 2 mlo links, link 1 is 5 GHz band, link 2
> > is 2.4 GHz band,
> > then the 2 probe reponse will be changed to a same one.
> > seems we should skip probe presponse for the mac address change here,
> > right?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=42fb9148c078004d07b4c39bd7b1086b6165780c
> >
> > wifi: mac80211: do link->MLD address translation on RX
> >
> Hi Johannes,
>
> May I get your comment about this?
Yes I've actually seen this issue as well.
> I did below change in my local test to workaround the issue.
>
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index a57811372027..eaff5353520a 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -4858,7 +4858,8 @@ static bool ieee80211_prepare_and_rx_handle(struct
> ieee80211_rx_data *rx,
> shwt->hwtstamp = skb_hwtstamps(skb)->hwtstamp;
> }
>
> - if (unlikely(link_sta)) {
> + if (unlikely(link_sta) &&
> + !(ieee80211_is_probe_resp(hdr->frame_control))) {
> /* translate to MLD addresses */
>
Maybe it should also be for beacons or so?
johannes
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
next prev parent reply other threads:[~2022-10-19 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e1c5fbac-7e6e-c643-f24d-32cec779f2d3@quicinc.com>
2022-10-19 9:35 ` wifi: mac80211: Re: unicast probe response bssid changed by "wifi: mac80211: do link->MLD address translation on RX" Wen Gong
2022-10-19 9:38 ` Johannes Berg [this message]
2022-10-19 9:40 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f652efb43226f67e932f5aaf97cd717992bfd81.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox