Re: [PATCH] wifi: ath12k: Allow driver initialization for WoW unsupported devices

[Jeff Johnson <quic_jjohnson@quicinc.com>]

On 6/25/2024 7:42 PM, Rameshkumar Sundaram wrote:
> Currently during driver initialization, mac registration is allowed
> only for devices that advertise WMI_TLV_SERVICE_WOW, but QCN9274
> doesn't support WoW and hence mac registration is aborted and driver
> is de-initialized.
> 
> Allow mac registration to proceed without WoW Support for devices
> that don't advertise WMI_TLV_SERVICE_WOW.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Cc: stable@vger.kernel.org
> Fixes: 4a3c212eee0e ("wifi: ath12k: add basic WoW functionalities")
> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/wow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/wow.c b/drivers/net/wireless/ath/ath12k/wow.c
> index 685e8e98d845..c5cba825a84a 100644
> --- a/drivers/net/wireless/ath/ath12k/wow.c
> +++ b/drivers/net/wireless/ath/ath12k/wow.c
> @@ -1001,8 +1001,8 @@ int ath12k_wow_op_resume(struct ieee80211_hw *hw)
>  
>  int ath12k_wow_init(struct ath12k *ar)
>  {
> -	if (WARN_ON(!test_bit(WMI_TLV_SERVICE_WOW, ar->wmi->wmi_ab->svc_map)))
> -		return -EINVAL;
> +	if (!test_bit(WMI_TLV_SERVICE_WOW, ar->wmi->wmi_ab->svc_map))
> +		return 0;
>  
>  	ar->wow.wowlan_support = ath12k_wowlan_support;
>  
> 
> base-commit: dadc1101eabb54ace51aa6fc58c902bf43ac0ed7
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>