Re: [PATCH v3 00/10] wifi: ath12k: P2P support for WCN7850

[<quic_kangyang@quicinc.com>]

On 1/29/24 9:02 PM, Kalle Valo <kvalo@kernel.org> wrote:
> Kang Yang <quic_kangyang@quicinc.com> writes:
> 
> > On 1/25/2024 10:44 PM, Kalle Valo wrote:
> >> Kang Yang <quic_kangyang@quicinc.com> writes:
> >>
> >>> Add P2P support for WCN7850.
> >>>
> >>> Kang Yang (10):
> >>>     wifi: ath12k: change interface combination for P2P mode
> >>>     wifi: ath12k: add P2P IE in beacon template
> >>>     wifi: ath12k: implement handling of P2P NoA event
> >>>     wifi: ath12k: implement remain on channel for P2P mode
> >>>     wifi: ath12k: change WLAN_SCAN_PARAMS_MAX_IE_LEN from 256 to 512
> >>>     wifi: ath12k: allow specific mgmt frame tx while vdev is not up
> >>>     wifi: ath12k: fix broken structure wmi_vdev_create_cmd
> >>>     wifi: ath12k: move peer delete after vdev stop of station for WCN7850
> >>>     wifi: ath12k: designating channel frequency for ROC scan
> >>>     wifi: ath12k: advertise P2P dev support for WCN7850
> >>>
> >>> v3: rebase on new ath-tag, use ath12k_ah_to_ar() get ar(Karthikeyan).
> >>> v2:
> >>>       1. add Tested-on tag of QCN9274.
> >>>       2. update copyright in patch #1, #2, #4 and #10.
> >> I have not been able to run any p2p tests yet but during rmmod with
> >> WCN7850 I now see:
> >> [  136.260660] ------------[ cut here ]------------
> >> [ 136.260909] UBSAN: shift-out-of-bounds in
> >> drivers/net/wireless/ath/ath12k/mac.c:6005:38
> >> [  136.261008] shift exponent 255 is too large for 64-bit type 'long long int'
> >
> >
> > It seems you enable CONFIG_UBSAN, CONFIG_UBSAN_SANITIZE_ALL and other
> > CONFIG_UBSAN_XXX.
> 
> Yes, I try to enable debug facilities as much as possible. They are
> really good at finding issues in the code.
> 
> > I will add them to my config file and debug this warning.
> 
> Thanks.
> 

Now, i fix this warning with new patch '[PATCH v6 02/11] wifi: ath12k: fix incorrect logic of calculating vdev_stats_id'.

Please ignore this version.


> > It's been a long time since the last update of kernel config. Can you
> > share the new one if convenient?
> 
> Yeah, it is. I updated it now.
> 
>