RE: [PATCH 23/50] wifi: ath12k: add hal_rx.h

Karthikeyan Periyasamy (QUIC)
2022-10-04T11:15:38Z

> -----Original Message-----
> From: Jeff Johnson <quic_jjohnson@quicinc.com>
> Sent: Thursday, August 18, 2022 5:52 AM
> To: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org
> Cc: ath12k@lists.infradead.org
> Subject: Re: [PATCH 23/50] wifi: ath12k: add hal_rx.h
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> On 8/12/2022 9:09 AM, Kalle Valo wrote:
> > From: Kalle Valo <quic_kvalo@quicinc.com>
> >
> > (Patches split into one patch per file for easier review, but the
> > final commit will be one big patch. See the cover letter for more
> > info.)
> >
> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> > ---
> > drivers/net/wireless/ath/ath12k/hal_rx.h | 694
> +++++++++++++++++++++++++++++++
> > 1 file changed, 694 insertions(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath12k/hal_rx.h
> > b/drivers/net/wireless/ath/ath12k/hal_rx.h
> > new file mode 100644
> > index 000000000000..883ea1be2525
> > --- /dev/null
> > +++ b/drivers/net/wireless/ath/ath12k/hal_rx.h
>
> snip
>
> > +static inline u32 ath12k_he_ru_tones_to_nl80211_he_ru_alloc(u16
> > +ru_tones)
>
> why doesn't this function return enum nl80211_he_ru_alloc

Sure will address this comment in the next version of the patch

>
> > +{
> > + u32 ret = 0;
>
> shouldn't this be initialized to a enum nl80211_he_ru_alloc enumerator?
> (0 is NL80211_RATE_INFO_HE_RU_ALLOC_26)
>
> or perhaps remove the initializer and add a default:?

Sure will address this comment in the next version of the patch

>
> > +
> > + switch (ru_tones) {
> > + case RU_26:
>
> add default: here?

Sure will address this comment in the next version of the patch

>
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_26;
> > + break;
> > + case RU_52:
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_52;
> > + break;
> > + case RU_106:
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_106;
> > + break;
> > + case RU_242:
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_242;
> > + break;
> > + case RU_484:
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_484;
> > + break;
> > + case RU_996:
> > + ret = NL80211_RATE_INFO_HE_RU_ALLOC_996;
> > + break;
> > + }
> > + return ret;
>
> snip

Thanks
Karthikeyan