Re: [PATCH 33/50] wifi: ath12k: add mhi.c

Jeff Johnson
2022-11-09T16:49:48Z

On 11/8/2022 6:00 AM, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>> +static struct mhi_event_config ath12k_mhi_events_qcn9274[] = {
>>
>> seems this should be const
>> but for some reason struct mhi_controller_config has:
>> struct mhi_event_config *event_cfg;
>>
>> (not const) so this can't be const :(
>>
>> perhaps someone can propose a MHI interface change?
>> especially since internally to MHI in parse_ev_cfg() we have:
>> const struct mhi_event_config *event_cfg;
>> [...]
>> for (i = 0; i < num; i++) {
>> event_cfg = &config->event_cfg[i];
>>
>> so it is treated as const
>
> You submitted a patch for this, thanks for that:
>
> https://lore.kernel.org/all/20220830171147.24338-1-quic_jjohnson@quicinc.com/
>
> But oddly I cannot find anywhere in git, I sent a question about that to
> the mhi list.

This was already discussed on the MHI list, but just to follow up here,
that MHI patch could not be accepted since there is one use case where
MHI needs to write back into the event_cfg.