RE: [PATCH 15/50] wifi: ath12k: add dp_rx.c

Sriram R (QUIC)
2022-10-14T02:43:51Z

>-----Original Message-----
>From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
>Sent: Thursday, October 13, 2022 12:19 PM
>To: Sriram R (QUIC) <quic_srirrama@quicinc.com>; Kalle Valo
><kvalo@kernel.org>; linux-wireless@vger.kernel.org
>Cc: ath12k@lists.infradead.org
>Subject: Re: [PATCH 15/50] wifi: ath12k: add dp_rx.c
>
>On 10/12/2022 4:29 PM, Sriram R (QUIC) wrote:
>>>> +static u16 ath12k_dp_rx_h_frag_no(struct ath12k_base *ab,
>>>> + struct sk_buff *skb) {
>>>> + struct ieee80211_hdr *hdr;
>>>> +
>>>> + hdr = (struct ieee80211_hdr *)(skb->data + ab->hw_params-
>>>> hal_desc_sz);
>>>> + return le16_to_cpu(hdr->seq_ctrl) & IEEE80211_SCTL_FRAG;
>>>
>>> should there be an ieee80211.h function for this? we already have:
>>> ieee80211_is_first_frag()
>>> ieee80211_is_frag()
>> Yeah, but we needed the frag no in this case.
>
>understand. so create an ieee80211_frag_number() function in ieee80211.h
Right. That could be added and used here,

Thanks,
Sriram.R