From: Kalle Valo <kvalo@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev, Sriram R <quic_srirrama@quicinc.com>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Jeff Johnson <jjohnson@kernel.org>,
ath12k@lists.infradead.org,
Rameshkumar Sundaram <quic_ramess@quicinc.com>
Subject: Re: [ath:ath12k-mlo-qcn9274 64/81] drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf() error: buffer overflow 'vif->link_conf' 15 <= 15
Date: Mon, 04 Nov 2024 22:19:34 +0200 [thread overview]
Message-ID: <875xp27nvt.fsf@kernel.org> (raw)
In-Reply-To: <207e7634-4390-47ac-bc62-c888f9dc34b4@stanley.mountain> (Dan Carpenter's message of "Wed, 9 Oct 2024 14:14:29 +0300")
Dan Carpenter <dan.carpenter@linaro.org> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath12k-mlo-qcn9274
> head: 7435d14d41d5d479a5e6a8a2cd4efdac9d928823
> commit: 8e3d460d4c16e52a70ebfa7e1dd0bd20bf739888 [64/81] wifi: ath12k:
> Use mac80211 vif's link conf instead of bss_conf
> config: csky-randconfig-r072-20241008
> (https://download.01.org/0day-ci/archive/20241009/202410090633.yjfmlMkr-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 14.1.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202410090633.yjfmlMkr-lkp@intel.com/
>
> New smatch warnings:
> drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf()
> error: buffer overflow 'vif->link_conf' 15 <= 15
> drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf()
> error: buffer overflow 'vif->link_conf' 15 <= 15
> drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf()
> error: buffer overflow 'vif->link_conf' 15 <= 15
> drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf()
> error: buffer overflow 'vif->link_conf' 15 <= 15
> drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf()
> error: buffer overflow 'vif->link_conf' 15 <= 15
>
> vim +517 drivers/net/wireless/ath/ath12k/mac.c
>
> 8e3d460d4c16e5 Sriram R 2024-08-16 507 struct ieee80211_bss_conf
> *ath12k_get_link_bss_conf(struct ath12k_link_vif *arvif)
> 8e3d460d4c16e5 Sriram R 2024-08-16 508 {
> 8e3d460d4c16e5 Sriram R 2024-08-16 509 struct ieee80211_vif *vif = arvif->ahvif->vif;
> 8e3d460d4c16e5 Sriram R 2024-08-16 510 struct ieee80211_bss_conf *link_conf;
> 8e3d460d4c16e5 Sriram R 2024-08-16 511 /* ieee80211_vif->link_conf[]s
> are rcu objects which requires rcu_read_lock()
> 8e3d460d4c16e5 Sriram R 2024-08-16 512 * to be held for safe access.
> 8e3d460d4c16e5 Sriram R 2024-08-16 513 */
> 8e3d460d4c16e5 Sriram R 2024-08-16 514 if (arvif->link_id > IEEE80211_MLD_MAX_NUM_LINKS)
>
> Seems like this is an off by one.
Yup, fixed version of the patch (not yet submitted for review):
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=ath12k-mlo&id=51a7ce0fc98b4fc70200cc113ec77a8159c40ca4
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-11-04 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:14 [ath:ath12k-mlo-qcn9274 64/81] drivers/net/wireless/ath/ath12k/mac.c:517 ath12k_get_link_bss_conf() error: buffer overflow 'vif->link_conf' 15 <= 15 Dan Carpenter
2024-11-04 20:19 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xp27nvt.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=dan.carpenter@linaro.org \
--cc=jjohnson@kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=quic_ramess@quicinc.com \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox