From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Subject: Re: [PATCH v4 4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function
Date: Tue, 14 Jan 2025 20:32:43 +0200 [thread overview]
Message-ID: <878qrdp7p0.fsf@kernel.org> (raw)
In-Reply-To: <20250112071630.4059410-5-quic_periyasa@quicinc.com> (Karthikeyan Periyasamy's message of "Sun, 12 Jan 2025 12:46:30 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> Currently, the uninitialized variable 'ab' is accessed in the
> ath12k_mac_allocate() function. Initialize 'ab' with the first radio device
> present in the hardware abstraction handle (ah). Additionally, move the
> default setting procedure from the pdev mapping iteration to the total
> radio calculating iteration for better code readability. Perform the
> maximum radio validation check for total_radio to ensure that both num_hw
> and radio_per_hw are validated indirectly, as these variables are derived
> from total_radio. This also fixes the below Smatch static checker warning.
>
> Smatch warning:
> ath12k_mac_allocate() error: uninitialized symbol 'ab'
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Fixes: a343d97f27f5 ("wifi: ath12k: move struct ath12k_hw from per device to group")
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> Acked-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2025-01-14 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 7:16 [PATCH v4 0/4] wifi: ath12k: Fix the static checker warning Karthikeyan Periyasamy
2025-01-12 7:16 ` [PATCH v4 1/4] wifi: ath12k: Refactor ath12k_hw set helper function argument Karthikeyan Periyasamy
2025-01-14 18:28 ` Kalle Valo
2025-01-14 18:29 ` Kalle Valo
2025-01-12 7:16 ` [PATCH v4 2/4] wifi: ath12k: Refactor the ath12k_hw get " Karthikeyan Periyasamy
2025-01-14 18:30 ` Kalle Valo
2025-01-12 7:16 ` [PATCH v4 3/4] wifi: ath12k: Remove ath12k_get_num_hw() helper function Karthikeyan Periyasamy
2025-01-13 16:12 ` Jeff Johnson
2025-01-14 18:31 ` Kalle Valo
2025-01-12 7:16 ` [PATCH v4 4/4] wifi: ath12k: Fix uninitialized variable access in ath12k_mac_allocate() function Karthikeyan Periyasamy
2025-01-14 18:32 ` Kalle Valo [this message]
2025-01-14 20:54 ` [PATCH v4 0/4] wifi: ath12k: Fix the static checker warning Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qrdp7p0.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox