Re: [PATCH] wifi: ath12k: Fix pdev id sent to firmware for single phy devices

[Kalle Valo <kvalo@kernel.org>]

Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:

> From: Lingbo Kong <quic_lingbok@quicinc.com>
>
> Pdev id from mac phy capabilities will be sent as a part of
> HTT/WMI command to firmware. This causes issue with single pdev
> devices where firmware does not respond to the WMI/HTT request
> sent from host.

But WCN7850 already works so I'm not really understanding the bug
description. Can you elaborate, please?

> @@ -81,5 +81,8 @@ int ath12k_mac_rfkill_config(struct ath12k *ar);
>  int ath12k_mac_wait_tx_complete(struct ath12k *ar);
>  void ath12k_mac_handle_beacon(struct ath12k *ar, struct sk_buff *skb);
>  void ath12k_mac_handle_beacon_miss(struct ath12k *ar, u32 vdev_id);
> +u8 ath12k_mac_get_target_pdev_id(struct ath12k *ar);
> +u8 ath12k_mac_get_target_pdev_id_from_vif(struct ath12k_vif *arvif);
> +struct ath12k_vif *ath12k_mac_get_vif_up(struct ath12k *ar);

AFAICS ath12k_mac_get_target_pdev_id_from_vif() and
ath12k_mac_get_vif_up() can be static, no need to add them to mac.h.

So we are left with ath12k_mac_get_target_pdev_id() but I don't see it
called anywhere. Isn't that dead code we are adding?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches