From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4350CC43602 for ; Fri, 3 Jul 2026 07:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+6pHyZxWbatKYOvCtdPwzFFfwFORFhjhD8Bmb0G9ebU=; b=H4PxK6j+kT2r//0JHmX+c4ThkO acmviatUJaMaktbYWjrwO+dkZZNmZXJRTEQLjLwW15OceaJZcMx2LJaJprbKcR1hEWIY3Aav+P4vL wet4HbRZzUE2umjGjwHczzEIArfglV6U4e01mqiYVNAORpVn0KsRvqeTH3WbDS3vsgVyUzFAMkGfA JohCWZnZ7iWts5liWT6cSL3S3954tpKlbAaK7n3rmLUUiBPyqHyIg9MA/0iqXPy80w74Wlhw4sQ9L KU2j9vHLzIRBGVetfytDtPLBKr2U5XZ7kScWwuTTT0i9orfxD+iPw7U0J6O3+yfIGoPn7Xceypavo eplh1Vjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfXyh-00000006FIg-09bO; Fri, 03 Jul 2026 07:06:23 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfXyf-00000006FIL-13Ky for ath12k@lists.infradead.org; Fri, 03 Jul 2026 07:06:22 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1783062366; cv=none; d=zohomail.com; s=zohoarc; b=KY2pLqh0ZoupfiQRZu/231n55A+2utR1GmdaW6v/YDTW5xlwVeX0eckyzZ0BFlrLccHtwty1zlqYLXCxosMppEQf9gHRYplpfWo9/U8n6ti2ZyoKQv8uH1wXZInAARVsfGILfJB8fxPjN9VQEO9VoHDp6/0paEsjPKq/3D6bSf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783062366; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=+6pHyZxWbatKYOvCtdPwzFFfwFORFhjhD8Bmb0G9ebU=; b=gbuZychvZJFfD/Pea2w8GZtqHyqzfV2d0E6kwHBDj9Hq6U3LGke7PmF+T42H6B1nmZQsQEMHL+sCbgfuvAbIX/rbfxQ0uKSg3DUzU+iMvqfvxGaXkSDD5bylR9BJ7Au8qrg1WCXQS3nErvY6UViL8VRSVUTMmQC1F/+5UmZnnE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=matthew.leach@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783062366; s=zohomail; d=collabora.com; i=matthew.leach@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=+6pHyZxWbatKYOvCtdPwzFFfwFORFhjhD8Bmb0G9ebU=; b=Mh05H89gDD/ygQkOhi/nOe+PmIAJuiAigKcFluPnBGaNiUVN5EGmtgQ5UUNgkZKd IB+CPUFQVOTPFR+cC23MeGgDoT6ZWdDwq2Eu5mQTmxT/ULCnoFDc1O9y/UulxQM9I5a 3II1lYpB377sK5xRvMOTr5drEqxDBkb+o1iZNZqY= Received: by mx.zohomail.com with SMTPS id 1783062364503160.63095399663666; Fri, 3 Jul 2026 00:06:04 -0700 (PDT) From: Matthew Leach To: "Nicolas Escande" Cc: "Jeff Johnson" , "Vasanthakumar Thiagarajan" , "Baochen Qiang" , "Ramya Gnanasekar" , "Karthikeyan Periyasamy" , "Pradeep Kumar Chitrapu" , "P Praneesh" , "Sriram R" , , , , , "Rameshkumar Sundaram" , "Rameshkumar Sundaram" , "Jeff Johnson" Subject: Re: [PATCH v2] wifi: ath12k: fix survey indexing across bands In-Reply-To: (Nicolas Escande's message of "Thu, 02 Jul 2026 23:14:34 +0200") References: <20260702-ath12-survey-band-fix-v2-1-75b5bdf72a08@collabora.com> User-Agent: mu4e 1.14.1; emacs 30.2 Date: Fri, 03 Jul 2026 08:06:00 +0100 Message-ID: <87ldbswo13.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260703_000621_617433_47015531 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org "Nicolas Escande" writes: > On Thu Jul 2, 2026 at 12:50 PM CEST, Matthew Leach wrote: >> When running 'iw dev wlan0 survey dump' the values for the channel busy >> time have the same sequence across bands. This is caused by indexing >> into the ath12k survey array using a band-local index rather than the >> global index passed by mac80211. This results in surveys for 5 GHz and 6 >> GHz channels returning values from 2.4 GHz slots, making the survey >> unusable on those bands. Further, there are redundant survey slots for >> multi-radio/single-phy instances. >> >> Fix by moving the survey data into ath12k_hw so multiple radios under a >> single wiphy share one table, and index into it using the global >> mac80211 index. A new spinlock in ath12k_hw serialises access to the >> survey array, which is now shared across all radios under a single hw. >> >> Band busy-times Before this fix: >> >> 2.4 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5 >> 5 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5 >> 6 GHz: 9, 2, 2, 2, 4, 2, 10, 16, 4, 12, 5 >> >> After this fix, times are independent: >> >> 2.4 GHz: 23, 5, 5, 12, 2, 12, 26, 5, 3, 1, 27 >> 5 GHz: 30, 40, 29, 27, 118, 118, 112, 120, 11, 11, 11 >> 6 GHz: 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1 >> >> Tested-on: wcn7850 hw2.0 PCI WLAN.IOE_HMT.1.1-00018-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1 >> > > Hello, Hi Nicolas, > I see that this is supposed to work on single phy device, but could someone > do a proper test to ensure that it will work on QCN9274 split phy ? > > I know this is a big ask, and usually I would do it, but I do not have a setup > with a new enough kernel running to test this right now. If you're looking at getting this tested on a split-phy, I'll get v3 pushed out asap which incorporates Rameshkumar's comment. Thanks, -- Matt