From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH RFC 1/4] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex
Date: Thu, 05 Sep 2024 19:52:26 +0300 [thread overview]
Message-ID: <87le06hwl1.fsf@kernel.org> (raw)
In-Reply-To: <a1a4202f-5c10-401a-9b02-47dacb9be048@quicinc.com> (Baochen Qiang's message of "Thu, 22 Aug 2024 13:46:37 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 8/21/2024 11:37 PM, Kalle Valo wrote:
>> @@ -845,7 +845,9 @@ int ath12k_wow_op_suspend(struct ieee80211_hw *hw,
>> struct ath12k *ar = ath12k_ah_to_ar(ah, 0);
>> int ret;
>>
>> - mutex_lock(&ar->conf_mutex);
>> + lockdep_assert_wiphy(hw->wiphy);
>> +
>> + wiphy_lock(ath12k_ar_to_hw(ar)->wiphy);
>
> we don't need this lock because it is already held by mac80211.
>
>> ret = ath12k_wow_cleanup(ar);
>> if (ret) {
>> @@ -913,7 +915,7 @@ int ath12k_wow_op_suspend(struct ieee80211_hw *hw,
>> ath12k_wow_cleanup(ar);
>>
>> exit:
>> - mutex_unlock(&ar->conf_mutex);
>> + wiphy_unlock(ath12k_ar_to_hw(ar)->wiphy);
>
> same here.
Ouch, that's bad. Will fix in v2, thanks!
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-05 16:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 15:37 [PATCH RFC 0/4] wifi: ath12k: switch to using wiphy_lock() Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 1/4] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex Kalle Valo
2024-08-22 5:46 ` Baochen Qiang
2024-09-05 16:52 ` Kalle Valo [this message]
2024-08-21 15:37 ` [PATCH RFC 2/4] wifi: ath12k: cleanup unneeded labels Kalle Valo
2024-08-21 16:55 ` Jeff Johnson
2024-09-05 16:49 ` Kalle Valo
2024-08-21 17:20 ` Johannes Berg
2024-09-05 17:09 ` Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 3/4] wifi: ath12k: ath12k_mac_op_set_key(): remove exit label Kalle Valo
2024-08-21 15:37 ` [PATCH RFC 4/4] wifi: ath12k: convert struct ath12k_sta::update_wk to use struct wiphy_work Kalle Valo
2024-08-22 6:19 ` Baochen Qiang
2024-09-05 16:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le06hwl1.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox