From: Kalle Valo <kvalo@kernel.org>
To: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
Cc: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
Karthik M <quic_karm@quicinc.com>
Subject: Re: [PATCH] wifi: ath12k: add wait operation for tx management packets for flush from mac80211
Date: Mon, 17 Apr 2023 15:56:24 +0300 [thread overview]
Message-ID: <87leiqwttz.fsf@kernel.org> (raw)
In-Reply-To: <20230405054646.7300-1-quic_rgnanase@quicinc.com> (Ramya Gnanasekar's message of "Wed, 5 Apr 2023 11:16:46 +0530")
Ramya Gnanasekar <quic_rgnanase@quicinc.com> writes:
> From: Karthik M <quic_karm@quicinc.com>
>
> Transmission of management packets are done in a work queue. Sometimes
> the workqueue does not finish Tx immediately, then it lead after the next
> step of vdev delete finished, it start to send the management packet to
> firmware and lead firmware crash.
>
> ieee80211_set_disassoc() have logic of ieee80211_flush_queues() after
> it send_deauth_disassoc() to ath12k, its purpose is make sure the
> deauth was actually sent, so it need to change ath12k to match the
> purpose of mac80211.
>
> To address these issues wait for Tx management as well as Tx data packets.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Karthik M <quic_karm@quicinc.com>
> Signed-off-by: Ramya Gnanasekar <quic_rgnanase@quicinc.com>
>
> diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
> index a89e66653f04..499b81cd938e 100644
Ramya, how do you submit your patches? Your patches are missing the
"---" line which breaks my scripts. I have asked this already before but
no reply from you:
https://lore.kernel.org/all/87edqot8m4.fsf@kernel.org/
Please do not ignore my questions. If you continue to do that I will
just stop taking patches from you.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
next prev parent reply other threads:[~2023-04-17 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 5:46 [PATCH] wifi: ath12k: add wait operation for tx management packets for flush from mac80211 Ramya Gnanasekar
2023-04-17 12:56 ` Kalle Valo [this message]
2023-04-17 14:31 ` Ramya Gnanasekar
2023-04-17 14:55 ` Ramya Gnanasekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leiqwttz.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_karm@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox