Re: [PATCH] wifi: ath12k: fix tx power, max reg power update to firmware

Kalle Valo
2024-09-09T09:08:06Z

"Nicolas Escande" <nico.escande@gmail.com> writes:

> On Mon Sep 9, 2024 at 9:30 AM CEST, Santhosh Ramesh wrote:
>
> [...]
>
>> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
>> index 137394c36460..6d7a005d83b4 100644
>> --- a/drivers/net/wireless/ath/ath12k/mac.c
>> +++ b/drivers/net/wireless/ath/ath12k/mac.c
>> @@ -7217,9 +7217,9 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif,
>> chandef->chan->band,
>> arvif->vif->type);
>> arg.min_power = 0;
>> - arg.max_power = chandef->chan->max_power * 2;
>> - arg.max_reg_power = chandef->chan->max_reg_power * 2;
>> - arg.max_antenna_gain = chandef->chan->max_antenna_gain * 2;
>> + arg.max_power = chandef->chan->max_power;
>> + arg.max_reg_power = chandef->chan->max_reg_power;
>> + arg.max_antenna_gain = chandef->chan->max_antenna_gain;
>>
>
> For what it's worth, I already got a similar patch from QCA a few month ago, and
> it fixed some tx power problems when scanning so I know there is truth in this.

What hardware and what firmware did you use? The firmware branches can
behave differently so whenever testing something it's good to include
that info.

--