Re: [PATCH] wifi: ath12k: fix tx power, max reg power update to firmware

Nicolas Escande
2024-09-09T13:03:33Z

On Mon Sep 9, 2024 at 1:15 PM CEST, Kalle Valo wrote:
> "Nicolas Escande" <nico.escande@gmail.com> writes:
>
> > On Mon Sep 9, 2024 at 11:07 AM CEST, Kalle Valo wrote:
> >
> >> "Nicolas Escande" <nico.escande@gmail.com> writes:
> >>
> >> > On Mon Sep 9, 2024 at 9:30 AM CEST, Santhosh Ramesh wrote:
> >> >
> >> > [...]
> >> >
> >> >> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> >> >> index 137394c36460..6d7a005d83b4 100644
> >> >> --- a/drivers/net/wireless/ath/ath12k/mac.c
> >> >> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> >> >> @@ -7217,9 +7217,9 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif,
> >> >> chandef->chan->band,
> >> >> arvif->vif->type);
> >> >> arg.min_power = 0;
> >> >> - arg.max_power = chandef->chan->max_power * 2;
> >> >> - arg.max_reg_power = chandef->chan->max_reg_power * 2;
> >> >> - arg.max_antenna_gain = chandef->chan->max_antenna_gain * 2;
> >> >> + arg.max_power = chandef->chan->max_power;
> >> >> + arg.max_reg_power = chandef->chan->max_reg_power;
> >> >> + arg.max_antenna_gain = chandef->chan->max_antenna_gain;
> >> >>
> >> >
> >> > For what it's worth, I already got a similar patch from QCA a few month ago, and
> >> > it fixed some tx power problems when scanning so I know there is truth in this.
> >>
> >> What hardware and what firmware did you use? The firmware branches can
> >> behave differently so whenever testing something it's good to include
> >> that info.
> >
> > Well what I tested was with the additionnal patch provided. So depending on
> > Santhosh response, I'll either give the proprer tested by tag, or if the patch
> > isn't needed. I'll need to find some time to test it :)
>
> Can you say what hardware (QCN9274 or WCN7850) you are using? I'm not
> asking for Tested-on tag, just some extra information to help the
> review.

Sure, I tested it with a QCN9274, in 2*2x2 (2.4GHz + 5GHz) in station mode with
a special firmware WLAN.WBE.1.2.1-00148.1-QCAHKSWPL_SILICONZ-8.
Without this, all probe requests sent by the firwmare during a scan (both bands)
were send with around 15/20 dBm less power that the data frames.