From: Kalle Valo <kvalo@kernel.org>
To: Aloka Dixit <quic_alokad@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
Subject: Re: [PATCH v2 06/11] wifi: ath12k: prepare EHT peer assoc parameters
Date: Wed, 12 Apr 2023 12:19:03 +0300 [thread overview]
Message-ID: <87r0sp8nlk.fsf@kernel.org> (raw)
In-Reply-To: <b3282c7d-07c5-8657-fca2-c286f82cb235@quicinc.com> (Aloka Dixit's message of "Mon, 10 Apr 2023 09:22:53 -0700")
Aloka Dixit <quic_alokad@quicinc.com> writes:
> On 4/3/2023 3:51 PM, Aloka Dixit wrote:
>
>> Add new parameters and prepare the association data for an EHT peer.
>> MCS data uses the format described in IEEE P802.11be/D2.0, May 2022,
>> 9.4.2.313.4, convert it into the format expected by the firmware.
>>
>> + case IEEE80211_STA_RX_BW_320:
>> + bw = &eht_cap->eht_mcs_nss_supp.bw._320;
>> + ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss,
>> + bw->rx_tx_mcs9_max_nss,
>> + bw->rx_tx_mcs11_max_nss,
>> + bw->rx_tx_mcs13_max_nss,
>> + &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320],
>> + &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320]);
>> + arg->peer_eht_mcs_count++;
>> + fallthrough;
>> +
>> + case IEEE80211_STA_RX_BW_160:
>> + bw = &eht_cap->eht_mcs_nss_supp.bw._160;
>> + ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss,
>> + bw->rx_tx_mcs9_max_nss,
>> + bw->rx_tx_mcs11_max_nss,
>> + bw->rx_tx_mcs13_max_nss,
>> + &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160],
>> + &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160]);
>> + fallthrough;
>> +
>
> 'arg->peer_eht_mcs_count++' is missing for 160 MHz case.
> Should I send a follow-up now for the series or wait for comments on
> the remaining part for some time.
Sending a new version sounds like the best.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k
next prev parent reply other threads:[~2023-04-12 9:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 22:51 [PATCH v2 00/11] wifi: ath12k: EHT support Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 01/11] wifi: ath12k: rename HE capabilities setup/copy functions Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 02/11] wifi: ath12k: move HE capabilities processing to a new function Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 03/11] wifi: ath12k: process EHT capabilities Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 04/11] wifi: ath12k: propagate EHT capabilities to userspace Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 05/11] wifi: ath12k: add EHT PHY modes Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 06/11] wifi: ath12k: prepare EHT peer assoc parameters Aloka Dixit
2023-04-10 16:22 ` Aloka Dixit
2023-04-12 9:19 ` Kalle Valo [this message]
2023-04-03 22:51 ` [PATCH v2 07/11] wifi: ath12k: add WMI support for EHT peer Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 08/11] wifi: ath12k: peer assoc for 320 MHz Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 09/11] wifi: ath12k: add MLO header in peer association Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 10/11] wifi: ath12k: parse WMI service ready ext2 event Aloka Dixit
2023-04-03 22:51 ` [PATCH v2 11/11] wifi: ath12k: configure puncturing bitmap Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0sp8nlk.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_alokad@quicinc.com \
--cc=quic_pradeepc@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox