From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH RFC v2 1/4] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex
Date: Tue, 24 Sep 2024 11:57:09 +0300 [thread overview]
Message-ID: <87setpa0pm.fsf@kernel.org> (raw)
In-Reply-To: <33963bc8-7cc9-434a-8910-cbcfc6fa965e@quicinc.com> (Baochen Qiang's message of "Thu, 19 Sep 2024 10:43:56 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 9/19/2024 2:10 AM, Kalle Valo wrote:
>> @@ -4310,7 +4301,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk)
>>
>> spin_unlock_bh(&ar->data_lock);
>>
>> - mutex_lock(&ar->conf_mutex);
>> + wiphy_lock(ath12k_ar_to_hw(ar)->wiphy);
>
> note in patch 4/4 ath12k_sta::update_wk is converted to use
> wiphy_work. While a wiphy work item is running wiphy lock is held
> already. So here try to acquire wiphy lock once again will lead to a
> deadlock.
Ouch again, thanks for catching this! This time I actually tested
changing bitrates and it shouldn't deadlock in v3. But I did notice
sleeping while atomic warnings (even without this patchset) and decided
to fix those in the same patchset as well.
Oh, and WCN6855 firmware was also crashing whenever I tried to change
the bitrates. But let's handle that separately.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-24 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 18:10 [PATCH RFC v2 0/4] wifi: ath12k: switch to using wiphy_lock() Kalle Valo
2024-09-18 18:10 ` [PATCH RFC v2 1/4] wifi: ath12k: switch to using wiphy_lock() and remove ar->conf_mutex Kalle Valo
2024-09-19 2:43 ` Baochen Qiang
2024-09-24 8:57 ` Kalle Valo [this message]
2024-09-24 10:03 ` Kalle Valo
2024-09-19 7:06 ` Johannes Berg
2024-09-24 9:11 ` Kalle Valo
2024-09-24 9:15 ` Johannes Berg
2024-09-18 18:10 ` [PATCH RFC v2 2/4] wifi: ath12k: cleanup unneeded labels Kalle Valo
2024-09-18 18:10 ` [PATCH RFC v2 3/4] wifi: ath12k: ath12k_mac_op_set_key(): remove exit label Kalle Valo
2024-09-18 18:10 ` [PATCH RFC v2 4/4] wifi: ath12k: convert struct ath12k_sta::update_wk to use struct wiphy_work Kalle Valo
2024-09-19 3:01 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87setpa0pm.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox