From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A481E7717F for ; Tue, 17 Dec 2024 15:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t7NDjHCk/ODHupwESL86oaIuyA+zeVQysuLnZu6CHYo=; b=DpN/Oodkcv7VyuKpcpJJ4ZGtVs k3Jul66JO2jgqehY1gnHLsmlH7HPio4tsznRfNRq0RWfxtDc0dPT0w75szzJomWQR9qhI2/utEC2E t0cS5xNeT/59pKA1cC5xG1VakjU94nVYXXEtdXPNiAncOKZ3Z8/mci/oZWWERSaRLEF7gBwZ4/+rM 7yqp2zH8AspZrD5qyk88CjM/FelEL+heQvKtW2s3/8TzlVJzg+ija7iTw4x0CQtjXaBNGsAR+zovI gSPs7i45yaHPWSAZZVdbyZkHgeZ2gRPQ5EPyy5rRsHW1AusI/bGKOhwqjb9D/uiwB+fBQHWdpKhZ2 JwSxwLWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNZCr-0000000Dtgq-1TWo for ath12k@archiver.kernel.org; Tue, 17 Dec 2024 15:09:53 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNZCp-0000000Dtfs-0TQn for ath12k@lists.infradead.org; Tue, 17 Dec 2024 15:09:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6C78D5C5F9B; Tue, 17 Dec 2024 15:09:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D8C8C4CED4; Tue, 17 Dec 2024 15:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734448190; bh=b6Ee/2FJS6CMMcv99DMPkaHN/TkaYLJhpK/5ku1jAy0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pgTGAvQ1jUoSGI2MvOGG13oa2mPn7jtJDSXm3Ej82B6I7OXyeof+rmdv6GdiIQotp 05f8qQWP6jwQC8LF0/JwRsEdJ1buQqobHGPPVdMWWQF+26hgHkH3rgPP/RKK2Xj7Lb Z/Hq5YcPclIQHgcGPcNqEKycaFQ5Xyx98Mi+MOt7vF894+h4/0apapJecJYnqgElIQ d/Csh5FXpayrOEtp2AP7xItrM1AZUAD/0LL+s7TMzOTP82yX7RSh0jX/67SQl6MRtG etWes5T5K5hx/HIZh3rhBPeX6RszJ4P+8RgCex4wb+6qAcIyTXn2/ny3I6VHcczHGx nuQ7024eLUSxA== From: Kalle Valo To: Roopni Devanathan Cc: , , Rajat Soni Subject: Re: [PATCH v4 2/2] wifi: ath12k: Support pdev Puncture Stats References: <20241217055408.1293764-1-quic_rdevanat@quicinc.com> <20241217055408.1293764-3-quic_rdevanat@quicinc.com> Date: Tue, 17 Dec 2024 17:09:47 +0200 In-Reply-To: <20241217055408.1293764-3-quic_rdevanat@quicinc.com> (Roopni Devanathan's message of "Tue, 17 Dec 2024 11:24:08 +0530") Message-ID: <87y10el51g.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241217_070951_238659_D43EF084 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org Roopni Devanathan writes: > From: Rajat Soni > > Add support to request pdev puncture stats from firmware through > HTT stats type 46. These stats give the count of number of > subbands used in different wifi standards. > > Sample output: > ------------- > echo 46 > /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats_type > cat /sys/kernel/debug/ath12k/pci-0000\:06\:00.0/mac0/htt_stats > HTT_PDEV_PUNCTURE_STATS_TLV: > mac_id = 0 > tx_ofdm_su_last_used_pattern_mask = 0x00000001 > tx_ofdm_su_num_subbands_used_cnt_01 = 217 > tx_ofdm_su_num_subbands_used_cnt_02 = 0 > tx_ofdm_su_num_subbands_used_cnt_03 = 0 > ..... > > HTT_PDEV_PUNCTURE_STATS_TLV: > mac_id = 0 > tx_ax_dl_mu_ofdma_last_used_pattern_mask = 0x00000000 > tx_ax_dl_mu_ofdma_num_subbands_used_cnt_01 = 0 > tx_ax_dl_mu_ofdma_num_subbands_used_cnt_02 = 0 > tx_ax_dl_mu_ofdma_num_subbands_used_cnt_03 = 0 > ..... > > HTT_PDEV_PUNCTURE_STATS_TLV: > mac_id = 0 > tx_be_dl_mu_ofdma_last_used_pattern_mask = 0x00000000 > tx_be_dl_mu_ofdma_num_subbands_used_cnt_01 = 0 > tx_be_dl_mu_ofdma_num_subbands_used_cnt_02 = 0 > tx_be_dl_mu_ofdma_num_subbands_used_cnt_03 = 0 > ..... > > HTT_PDEV_PUNCTURE_STATS_TLV: > mac_id = 0 > rx_ax_ul_mu_ofdma_last_used_pattern_mask = 0x00000000 > rx_ax_ul_mu_ofdma_num_subbands_used_cnt_01 = 0 > rx_ax_ul_mu_ofdma_num_subbands_used_cnt_02 = 0 > rx_ax_ul_mu_ofdma_num_subbands_used_cnt_03 = 0 > ..... > > HTT_PDEV_PUNCTURE_STATS_TLV: > mac_id = 0 > rx_be_ul_mu_ofdma_last_used_pattern_mask = 0x00000000 > rx_be_ul_mu_ofdma_num_subbands_used_cnt_01 = 0 > rx_be_ul_mu_ofdma_num_subbands_used_cnt_02 = 0 > rx_be_ul_mu_ofdma_num_subbands_used_cnt_03 = 0 > ..... > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Rajat Soni > Signed-off-by: Roopni Devanathan [...] > +static const char* > +ath12k_htt_get_punct_dir_type_str(enum ath12k_htt_stats_direction direction, > + struct debug_htt_stats_req *stats_req) > +{ > + const char *direction_str = "unknown"; > + u32 len = stats_req->buf_len; [...] > + > + stats_req->buf_len = len; What's the idea with len here? I don't get it. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches