From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
neil.armstrong@linaro.org,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jeff Johnson <jjohnson@kernel.org>,
Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH net] wifi: ath12k: properly set single_chip_mlo_supp to true in ath12k_core_alloc()
Date: Wed, 19 Mar 2025 11:27:41 +0100 [thread overview]
Message-ID: <8b05760b-db99-4b43-8444-d655b18d3699@kernel.org> (raw)
In-Reply-To: <7b4b598f-bc13-aa4b-8677-71477e1f5434@quicinc.com>
On 19/03/2025 10:06, Vasanthakumar Thiagarajan wrote:
>>>> ---
>>>> base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6
>>>> change-id: 20250303-topic-ath12k-fix-crash-49e9055c61a1
>>>>
>>>> Best regards,
>>>
>>> NAK since this will break QCN
>>> There is a series under internal review to address MLO issues for WCN chipsets
>>
>> ???
>>
>> The original commit is wrong, this fixes the conversion, nothing else.
>
> Nope. Driver changes to enable MLO with WCN chipset are not there yet.
> Setting the mlo capability flag without having required driver changes
> for WCN chipset will likely result in firmware crash. So the recommendation
> is to enable MLO (in WCN) only when all the necessary driver changes
> (in development, public posting in near future) are in place.
Really, these are your answers? There is regression and first reply is
upstream should wait for whatever you do internally. Second answer is
the same - public posting in near future?
Can you start working with the upstream instead?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-19 10:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 15:00 [PATCH net] wifi: ath12k: properly set single_chip_mlo_supp to true in ath12k_core_alloc() Neil Armstrong
2025-03-18 16:35 ` Jeff Johnson
2025-03-19 8:04 ` Neil Armstrong
2025-03-19 9:06 ` Vasanthakumar Thiagarajan
2025-03-19 9:12 ` neil.armstrong
2025-03-19 9:46 ` Baochen Qiang
2025-03-19 10:00 ` neil.armstrong
2025-03-19 10:18 ` Dmitry Baryshkov
2025-03-19 10:21 ` neil.armstrong
2025-03-19 10:23 ` Dmitry Baryshkov
2025-03-19 10:33 ` Krzysztof Kozlowski
2025-03-19 11:22 ` Dmitry Baryshkov
2025-03-19 11:31 ` Dmitry Baryshkov
2025-03-19 10:29 ` Krzysztof Kozlowski
2025-03-19 11:25 ` Dmitry Baryshkov
2025-03-20 7:21 ` Krzysztof Kozlowski
2025-03-19 18:24 ` Jeff Johnson
2025-03-19 10:27 ` Krzysztof Kozlowski [this message]
2025-03-19 11:32 ` Vasanthakumar Thiagarajan
2025-03-19 11:51 ` Dmitry Baryshkov
2025-03-19 12:54 ` Vasanthakumar Thiagarajan
2025-03-19 13:33 ` Dmitry Baryshkov
2025-03-19 17:23 ` Vasanthakumar Thiagarajan
2025-03-20 7:23 ` Vasanthakumar Thiagarajan
2025-03-20 10:06 ` neil.armstrong
2025-03-19 18:32 ` Jeff Johnson
2025-03-20 10:14 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b05760b-db99-4b43-8444-d655b18d3699@kernel.org \
--to=krzk@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_vthiagar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox