Re: [PATCH 06/13] wifi: nl80211: send iface combination to user space in multi-hardware wiphy

Johannes Berg
2024-04-10T06:59:21Z

On Wed, 2024-04-10 at 09:40 +0530, Karthikeyan Periyasamy wrote:
> > I agree, more duplication. So we have to have the per_hw_comb_attrs
> > defines like below?
> >
> > enum nl80211_if_comb_per_hw_comb_attrs {
> >     NL80211_IFACE_COMB_PER_HW_COMB_UNSPEC,
> >     NL80211_IFACE_COMB_PER_HW_COMB_HW_IDX =
> >             NL80211_IFACE_COMB_NUM_CHANNELS + 1,
> >     /* keep last */
> >     NUM_NL80211_IFACE_COMB_PER_HW_COMB,
> >     MAX_NL80211_IFACE_COMB_PER_HW_COMB =
> >             NUM_NL80211_IFACE_COMB_PER_HW_COMB - 1
> > };
> >
>
> @johannes Berg
>
>
> Any comments on the vasanth suggested approach ?

Think about it, do you have any comments? I mean, you've _already_ sent
an email, why not actually say something about the topic?

johannes