Re: [PATCH 06/13] wifi: nl80211: send iface combination to user space in multi-hardware wiphy

Jeff Johnson
2024-03-28T16:19:38Z

On 3/28/2024 6:33 AM, Johannes Berg wrote:
> On Thu, 2024-03-28 at 12:59 +0530, Karthikeyan Periyasamy wrote:
[...]
>> + hw_combis = nla_nest_start(msg, NL80211_IFACE_COMB_PER_HW_COMB);
>> + if (!hw_combis)
>> + return -ENOBUFS;
>> +
>> + for (i = 0; i < c->n_hw_list; i++) {
>> + struct nlattr *hw_combi, *limits;
>> +
>> + hw_combi = nla_nest_start(msg, i + 1);
>
> And of course the array and splitting discussions apply here too.

This is where I meant to say that I believe we are trying to reuse the same
structure and code as the wiphy-global combinations