Re: [PATCH v3 01/13] dt-bindings: net: wireless: describe the ath12k AHB module

Krzysztof Kozlowski
2024-12-10T07:18:58Z

On 09/12/2024 17:56, Raj Kumar Bhagat wrote:
> Add device-tree bindings for the ATH12K AHB module found in the IPQ5332
> device.

Please start using b4... Not tested, so no review.


Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.


Best regards,
Krzysztof