From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A3F4CD37B4 for ; Wed, 4 Sep 2024 12:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z1KWf2mb6RbNpV+nqCd2TtSzZK4N0VOuWNNoePqETtk=; b=TfAoSMO/O/TcDMo1rWBatpMAVc RVRqKCiIsII7kJVbH5IvmgnLEsWdB1786xGfg3Y69s9cwij9mDes1aKqzsk46qfVO+SM43Qt3wpmD m4xTkHOn2h82W+qWugUM3O05J5Ptr8nGBdMffEPHhBIrwmfFsueRBvokeiQWyWR4b94P/GNB2IAG+ fsj4v3zsyaC99SYtI816/xHb6YZzN+oULCYrUXHx3XVaTqZobAQThhC7B0KvciGxACewYat0hPxTA ETrgA1+RJIpXaYbjmaNfrEbkrfVzBnRfcsRPo2lkclM2lIUKLuCw+do+m/lN8LIe1DQ2CYWEgVNuQ efPoPPNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slokp-00000004Gsm-36nS for ath12k@archiver.kernel.org; Wed, 04 Sep 2024 12:04:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sloP8-00000004ChM-0Kss for ath12k@lists.infradead.org; Wed, 04 Sep 2024 11:42:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C5FE95C56A8; Wed, 4 Sep 2024 11:42:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBDB2C4CEC2; Wed, 4 Sep 2024 11:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725450148; bh=w8kcqUEtN5JVUmVZ23b/Gt3v6OD3N0jhoFRdRc0foyI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NoAjEFMwY2D2qZ/K1GfTWS5ZCaLg8XSWj8uv3ba4k/iZPseAYG1Nv35A7a3iKIbPR aa0JSDQgovsilp8piop4Y8O2XJLDdHBzef7yhFrxwNqJdbU8LOo2KLtkKZm+rBmiRb KMna9X3X7uzanOpm2UbJLWXPbr6LP5S/7gdIA+Tu62N9m7Lj929PWFum7Od7ZiAT9u xGBZN3CBhNVuD85Tqw900awq7AoSYsy66iz1MV80DT3u47D0TtjpmJQ9B87ByCVweV 3XaZbHzXkLVp8T5pHMp4/ufdz2nWMg+MtUtuzLwhT+jSIEPryTflR1bPhvlsYi8EZG CmqGBZTjNWZzw== Message-ID: Date: Wed, 4 Sep 2024 13:42:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 01/18] dt-bindings: net: wireless: describe the ath12k AHB module To: Raj Kumar Bhagat , ath12k@lists.infradead.org Cc: linux-wireless@vger.kernel.org References: <20240814094323.3927603-1-quic_rajkbhag@quicinc.com> <20240814094323.3927603-2-quic_rajkbhag@quicinc.com> <6a740dee-464a-4a10-9c25-ee6f0d22b279@kernel.org> <1e2a2974-b78b-483f-9190-34d5dae69f7d@kernel.org> <9e40f028-dc71-41cb-a5ac-772ef91129ac@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <9e40f028-dc71-41cb-a5ac-772ef91129ac@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_044230_412533_B1F6A56C X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 04/09/2024 13:28, Raj Kumar Bhagat wrote: > On 9/4/2024 1:08 PM, Krzysztof Kozlowski wrote: >> On 04/09/2024 09:23, Raj Kumar Bhagat wrote: >>>>> + qcom,board_id: >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + description: >>>>> + Board id value, it identifies the variant of ath12k WiFi device. >>>> >>>> Please do not upstream whatever you have in your vendor tree... You even >>>> copied its style! There is no such property in upstream. >>>> >>>> NAK, you are duplicating compatibles. >>>> >>>> >>> >>> qcom,board_id is a new parameter introduced to distinguish between different variants >>> of ath12k devices that share the same compatible value. This differentiation is crucial >>> as these variants have different qcom,board_id values (with the same compatible) based >> >> You must explain why compatible cannot be used for that. >> > > The compatible property is used to define the variant of the Ath12k device. However, the > Ath12k device variant does not change with different capabilities or configurations > (e.g., operating band). The qcom,board_id parameter is introduced to define these > configurations, not the device variant itself. operating aspects are run-time, so not suitable here. It's all still vague for me. > >>> on WiFi frequency bands capability. For example, 2 GHz, 5 GHz, 6 GHz, or multi-band >>> variants of ath12k devices have different qcom,board_id values. >>> >>> In the next version, I will include the above information in the qcom,board_id >>> description. >> >> Please follow DTS coding style. And style of existing properties like >> this. Did you look for them? I claim you just sent whatever you had in >> downstream. >> > > Checked "Devicetree Specification, Release v0.4", section 4.1.1, > seems "_" to be avoided for property name and hyphen "-" to be used. Also, qcom,board-id > is already taken in "Documentation/devicetree/bindings/arm/qcom.yaml". In the next > version will change this property name. Look at existing bindings and see how they are doing it. Sorry, you still did not give any good rationale why compatibles cannot be used. If this is board specific implementation, then the board compatible defines differences. You need to be specific, not so vague, about problem you are solving. Don't answer with half-baked explanations just to get rid of reviewer. Best regards, Krzysztof