From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B59B0EA854B for ; Mon, 9 Mar 2026 09:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:Date:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xbMtvtdOfLDdatvp+5lzCch6oMIueR07h2NcUioWpFw=; b=zjmGzEltjDm6cFydrChs09Eski lH1JappYwevHF4pBlvuaaeP947Cu4GaeOxaYI/Sc7NQmTSXXWZ2uuaMKnRUKwFzt3sjACB0bGJRR4 9QnjVzl0R6etuGHMZQq1xZenxLB49Aqr0VFxo1JPePwl8tP83DUxFd6gw1AGHeSTn8RPJnjna6MkQ v4AamYWbWzeCKCWxB7F+cdnyuyE1BsEQBy4wSa7HVceE2TkVOD/JOc/JXMB5BMqSTEDUeqjWRmsK0 JOFJSqfQOrs/KgR/GPFnmr9SUisDJ7URSsGJMDslu+1pMlSaTvBnKd42f91FHZaItmybBHF8HZ7Rz qF9Z+CGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzWet-00000006wPV-1szm; Mon, 09 Mar 2026 09:12:15 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzWer-00000006wOK-1HdN for ath12k@lists.infradead.org; Mon, 09 Mar 2026 09:12:14 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6297xDXI200749 for ; Mon, 9 Mar 2026 09:12:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=xbMtvtdOfLDdatvp+5lzCch6 oMIueR07h2NcUioWpFw=; b=jHru3esdNzuncTNwyW211a+aJdCkYiYxILsoZN+3 1GwgTcHiMn/ymHOV08WINAfoWlfYw32mmtmF+Seo9nDBKL/8faTBqtOibVjY8T1b dgaY0uA7GYpKzy2BlixGrj6mN62goEwdjRuKoxo3BmtDppXIOIRCT3W6eZFhNujG NUVHihFT8lC0N4D4b9D4sUu9vqiYV7661k24lzZtWboU4mtxwP07+llelKSKDhOL XCCcln8fcMYU0Dbq9i5aXPPkIr1kAbbwT4ojrN+2XxrTTpUirMmL8EjgT/DODPGl DyxQTsHS6r2QOpA4ooTD4DOGq2QorD2Gt3YNLkNIxsnfsg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crc3vcpjy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 09:12:11 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd77502295so1068378185a.1 for ; Mon, 09 Mar 2026 02:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773047531; x=1773652331; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=xbMtvtdOfLDdatvp+5lzCch6oMIueR07h2NcUioWpFw=; b=bzVvZWbMoYqjALXUKvtXJVgovTneE/tevlH+tigzVG3Tfzk2F4eQo6R8aIm7TXeFXl R8qakf2oEqlNMEHYLemOu5Xxq5xUl3UnniBE9f+2YwvntmwK3C4w9FY3bMJ+l+kdYmqj Yzvy5ujv9XsuJ4e1xyuwo6mikv7OJnNPCXBGIlQVrsZgH1KH1mVDwcaw2Tmr/csSJJyM ZgmGdMHHKw6x53NngjmdRhiFVoec2I5CNlt27PBJefyp3akxSwP3yaeNzGFau2T/UL+Z DSOxeujnostI5QH/MVPyR9Y08URgq9+4lUQLUAGcSlRH1lfj6rZAHLL9xqsJnLjdGDvH ts5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773047531; x=1773652331; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xbMtvtdOfLDdatvp+5lzCch6oMIueR07h2NcUioWpFw=; b=t9ZE4UwZOV1KHFz0us0i0iIyyYeN5iRhd5HuaSjt77SD6mqDVQZa9eVqh0YhJTalOg TeY0ZQRPkERZ2ZVoOnWSr1gSk1uvNMJ1BfPVjwWU+N1D9EYM3beAL6KwGRGoTSoacZTp +V8r/MNM5ApJBcvTcSFBJedonpJaQ0fKOm363ae9C7Xw2xfg0Pk2CN+eDdPKdH2Avw7V t7mIa880iyF8joVa/9MpIL9JQmqjwZi+6VYFV4wFlXdHATCeXvHbE508ZW5hyqioU9rO cI5jSN8iiSpJ3kriphR10/m+hJ0HOg/EviTMWO3FiWSRj5FOorfIKext4ZtYTLmYw6Gs gVsg== X-Forwarded-Encrypted: i=1; AJvYcCXcmfGbE1rfXkvuNJBWPGywZImoRng0o4myVhoV1GCJ9Mez7uhcX6PVB3UOI44JXG5+yQJxuOo=@lists.infradead.org X-Gm-Message-State: AOJu0YxJw0oydcRdGbMDfzryNSJFknFQbfm4VjUwpb1wsXB58ULsGGt7 K27/rQoC1np4k9wGIRxoTYmgki1ILpGCFgHOxRChbElxzfZVVU8V5REeqXBJuPNB2TUE/03k7FG 10OJ9iR6faVIHGy2pevy6AJSMhrY3N+ANV3faK8grg6sh4oELAMVJSLy1LU9vxcqA X-Gm-Gg: ATEYQzykZaSVn43ol/EyzuE5fgU8BQ7U9K+ab/WPZxUYgAKREw/fJVwbVogXSJrJ9Df VOU3kEx+Sww6/2UDJ+7us3ewLYftufAT0lSfpRGQM2EgqJDuBLAYZkcJAVd3e72hfEy1cSGuDCY Ep5apIyd+XlLl9wreyTfFXIPusQzzZPW/4boDA+vTlMvKxXuMQ2Tc9v6lfHsLFoxqwlky63fNkJ XEXwdbWu19KrCrZ+lIeQ1bMvkucj/EJJyfSBOUXYK8WpcFJ2zuY/AQPkAzd+nAQKwMprWYQ5PxU bvv9gOO5zIcLoVg2BBadJ1taGHW4yYTJslyckoQySyd4a1jdWk35IkDqUTsUVb7IGkOgWhx+Ydo C/uT+HO9yXa2WEg/5Kjee0vBgc9gfZ9N2exLi2llKhcjZUYa7tpuwcg== X-Received: by 2002:a05:620a:700a:b0:8c9:f9c1:5ed with SMTP id af79cd13be357-8cd6d4d541dmr1304568585a.63.1773047530893; Mon, 09 Mar 2026 02:12:10 -0700 (PDT) X-Received: by 2002:a05:620a:700a:b0:8c9:f9c1:5ed with SMTP id af79cd13be357-8cd6d4d541dmr1304566385a.63.1773047530429; Mon, 09 Mar 2026 02:12:10 -0700 (PDT) Received: from trex (110.red-81-38-138.dynamicip.rima-tde.net. [81.38.138.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae483desm23179497f8f.34.2026.03.09.02.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 02:12:09 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 9 Mar 2026 10:12:06 +0100 To: Sumit Garg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, Sumit Garg Subject: Re: [PATCH 11/14] media: qcom: Switch to generic PAS TZ APIs Message-ID: References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-12-sumit.garg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306105027.290375-12-sumit.garg@kernel.org> X-Proofpoint-ORIG-GUID: BB91DFZgyYSHQICGmcjTZadwyKkIc48H X-Proofpoint-GUID: BB91DFZgyYSHQICGmcjTZadwyKkIc48H X-Authority-Analysis: v=2.4 cv=OOQqHCaB c=1 sm=1 tr=0 ts=69ae8eeb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=P2IcWdTxk7sEx2G8DnB30w==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=zah51VvIpe4vvf6E17kA:9 a=CjuIK1q_8ugA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA4NCBTYWx0ZWRfX8fcB40oFOVgv VhZ1qf7GWdc5sEd7LH/uADuNm1PKb38BqZhGU5poZo/5QmMmtpFyX6SGnmZpDEgLd3NpAm9odA5 T/vCAvFgSqQvtJkJ9dgIs7sAztFNAXOPFMRCnoQqIywqPFgRs5vSi0XnphMFfZ+mj6/25QkImzp CoiOj7rWKwssdrWAXte34biTSpEX0dmp/pGunfq9AAM/Pl8YhFy2TPMbpOwzNqzXwvnH/sM07WE b6m65IVKMyusrgtuNkoK05mF1BnNLoZtrBxkgFUggvo/2ELP6VDCk5W1khlkZ+b3BeFW05nMCSf 3Eo+F4vbvJkQ3+3ZU/hvOUI6/ZduNLoq0uegdduh0cUiuS2Xs2F9hDFyA1SQnXQI6Cn01p5M8Eq nXo9h2bm7Jp5In2a3BvBeXT3LS/oRdgX7OnAqzdrXCYGasnQ42gPkYpOvEPm8IXR0UHjTJyKTWu hrY3AGNTiwiFaJEf0xQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090084 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260309_021213_465435_778317A8 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 06/03/26 16:20:24, Sumit Garg wrote: > From: Sumit Garg > > Switch qcom media client drivers over to generic PAS TZ APIs. Generic PAS > TZ service allows to support multiple TZ implementation backends like QTEE > based SCM PAS service, OP-TEE based PAS service and any further future TZ > backend service. > > Signed-off-by: Sumit Garg > --- > drivers/media/platform/qcom/iris/iris_firmware.c | 9 +++++---- > drivers/media/platform/qcom/venus/firmware.c | 11 ++++++----- > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > index 5f408024e967..b3c5281aea91 100644 > --- a/drivers/media/platform/qcom/iris/iris_firmware.c > +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > @@ -4,6 +4,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) > return -ENOMEM; > } > > - ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); > + ret = qcom_pas_auth_and_reset(core->iris_platform_data->pas_id); > if (ret) { > dev_err(core->dev, "auth and reset failed: %d\n", ret); > return ret; > @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) > cp_config->cp_nonpixel_size); > if (ret) { > dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); > - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); > + qcom_pas_shutdown(core->iris_platform_data->pas_id); > return ret; > } > } > @@ -103,10 +104,10 @@ int iris_fw_load(struct iris_core *core) > > int iris_fw_unload(struct iris_core *core) > { > - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); > + return qcom_pas_shutdown(core->iris_platform_data->pas_id); > } > are the calls to set_remote_state required? 0 is not the IRIS/VENUS remote processor. If it is legacy, maybe they can be phased out? > int iris_set_hw_state(struct iris_core *core, bool resume) > { > - return qcom_scm_set_remote_state(resume, 0); > + return qcom_pas_set_remote_state(resume, 0); > } > diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > index 1de7436713ed..3a38ff985822 100644 > --- a/drivers/media/platform/qcom/venus/firmware.c > +++ b/drivers/media/platform/qcom/venus/firmware.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) > int ret; > > if (core->use_tz) { > - ret = qcom_scm_set_remote_state(resume, 0); > + ret = qcom_pas_set_remote_state(resume, 0); > if (resume && ret == -EINVAL) > ret = 0; > return ret;