From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CB47F30297 for ; Mon, 16 Mar 2026 02:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+t5G4Irv4dhwRSJ9FVhPVUVdEgWEqIjYl8+gDa27gP0=; b=EhsYHYT6FL14ZIehzdgzNCdvRP KB1mcWVUPHS+CcPYCRVbZa4Aj2YH/9/ODMq280lJXPrlbKuao1CzJ3MLejWgWIy02oJvNWcwGPeoA +kf5PrUMLi8JzzYP934N4uX0bcPSbc0hkVxPFOG9R2ReXj8TxX9xIIAbzi9M8kR14E5yYLSxPAYR8 e1Dzv4qu50TQaSUehMDEZpunoyH9DmqbabnJ5I6x2Mgx4E2fSOaPKaSx/y0bTFPfivDxNymgHH/5s Ip6KOwohiwjAiPMtjXyBab5whUkTO+N8F2m+BigRqxcI3HrM/xqG1KsYCmHQUJzytTBywjeHpPcXI YUnOANqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1xHq-000000039nr-0U5y; Mon, 16 Mar 2026 02:02:30 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1xHn-000000039ms-06O8; Mon, 16 Mar 2026 02:02:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2ACF860008; Mon, 16 Mar 2026 02:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24C2DC2BC9E; Mon, 16 Mar 2026 02:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773626545; bh=kkXUNwiD69Xpf87E5BcMyOtlNTMPeQ7/lEHjHLgRL+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PaY9HkVEV6krRsQgLxwkiO7yZMgrlVrPpLXeYQAR7IAx5MDR7TUwQaFz5V5qBSv+A 3YoimJldxSYQPdNcTuf1q8DiCAdq3vsH/5xg42nBbHksinhtYNfrYPZega6m4y/sYo dSVfROBNQjnwOQiwv2Iv9yfHYtnCcqA+93lxvlHWuuM58XLuXbmq+J2EL7r6iTqBTr Zn8z8tWJ2xCvEIfT8gIb/4uorPM0rZ/envKWWfSJ/4LQJZFfI5sEgx7a5FPCeNQBPE 96u6lp0SEhMsftM3FyXouu+2DSxMYqsHHr06OStUhqnzmBbQFyHf9bdRGjM036xEQk f7OGCBrm7fLPg== Date: Sun, 15 Mar 2026 21:02:19 -0500 From: Bjorn Andersson To: Daniel Lezcano Cc: Jeff Johnson , konradybcio@kernel.org, linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header Message-ID: References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> <9cc7638f-1232-4cb7-b4d7-cdac66a2f4ba@oss.qualcomm.com> <3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com> X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On Tue, Mar 10, 2026 at 01:09:08AM +0100, Daniel Lezcano wrote: > On 3/10/26 00:50, Jeff Johnson wrote: > > On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > > > The different subsystems implementing the QMI service protocol are > > > using their own definition of the service id. It is not a problem but > > > it results on having those duplicated with different names but the > > > same value and without consistency in their name. > > > > > > It makes more sense to unify their names and move the definitions in > > [ ... ] > > > prefix for wireless drivers is simply wifi: : > > so s/net: drivers: wireless:/wifi:/ > > Noted, thanks > > > > remoteproc: qcom: Use the unified QMI service ID instead of defining > > > it locally > > > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > > > defining it locally > > > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > > > locally > > > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > > > defining it locally > > > samples: qmi: Use the unified QMI service ID instead of defining it > > > locally > > > > > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > > > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > > > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > > > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > > > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > > > drivers/remoteproc/qcom_sysmon.c | 2 +- > > > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > > > drivers/soc/qcom/pdr_interface.c | 4 ++-- > > > drivers/soc/qcom/pdr_internal.h | 3 --- > > > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > > > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > > > samples/qmi/qmi_sample_client.c | 2 +- > > > sound/usb/qcom/qc_audio_offload.c | 2 +- > > > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - > > > > You are touching a lot of subsystems with a single series. > > How do you plan on having these land? > > Do you have a maintainer who will take all of these through their tree? > > Yes I thought Bjorn or Konrad would take them with the acked-by from the > different subsystems As we haven't received any such acks, I pulled patch 1 into an immutable branch and pushed it here: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com Other maintainers can use this to pull respective changes, or you can repost the individual patches with this (or follow up once it's in -rc1). Regards, Bjorn