From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Sumit Garg <sumit.garg@kernel.org>,
andersson@kernel.org, konradybcio@kernel.org,
Sowmiya Sree Elavalagan <sowmiya.elavalagan@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-remoteproc@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
robin.clark@oss.qualcomm.com, sean@poorly.run,
akhilpo@oss.qualcomm.com, lumag@kernel.org,
abhinav.kumar@linux.dev, jesszhan0024@gmail.com,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, vikash.garodia@oss.qualcomm.com,
dikshita.agarwal@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jjohnson@kernel.org,
mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com,
mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com,
jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com,
vignesh.viswanathan@oss.qualcomm.com,
srinivas.kandagatla@oss.qualcomm.com,
amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org,
op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com,
skare@qti.qualcomm.com, linux-kernel@vger.kernel.org,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: Re: [PATCH v5 14/16] wifi: ath12k: Switch to generic PAS TZ APIs
Date: Tue, 5 May 2026 07:50:03 -0700 [thread overview]
Message-ID: <ae68bdb3-d683-4e7a-a27f-739214656ce2@oss.qualcomm.com> (raw)
In-Reply-To: <3bfdc11c-115f-45ab-b0ab-75ad88dc6f31@oss.qualcomm.com>
On 5/5/2026 7:27 AM, Jeff Johnson wrote:
> On 5/4/2026 6:06 AM, Sumit Garg wrote:
>> @@ -485,9 +485,9 @@ static void ath12k_ahb_power_down(struct ath12k_base *ab, bool is_suspend)
>> pasid = (u32_encode_bits(ab_ahb->userpd_id, ATH12K_USERPD_ID_MASK)) |
>> ATH12K_AHB_UPD_SWID;
>> /* Release the firmware */
>> - ret = qcom_scm_pas_shutdown(pasid);
>> + ret = qcom_pas_shutdown(pasid);
>> if (ret)
>> - ath12k_err(ab, "scm pas shutdown failed for userPD%d\n",
>> + ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n",
>> ab_ahb->userpd_id);
>
> at some point the "ret" param was dropped, and this now generates build warnings
The 'ret' param was dropped by:
8fb66931fe31 ("wifi: ath12k: Enable IPQ5424 WiFi device support")
Not sure if that was on purpose or accidental. Sowmiya?
- if (ret)
- ath12k_err(ab, "scm pas shutdown failed for userPD%d: %d\n",
- ab_ahb->userpd_id, ret);
...
+ if (ret)
+ ath12k_err(ab, "scm pas shutdown failed for userPD%d\n",
+ ab_ahb->userpd_id);
next prev parent reply other threads:[~2026-05-05 14:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 13:05 [PATCH v5 00/16] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-05-04 13:05 ` [PATCH v5 01/16] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-05-04 13:05 ` [PATCH v5 02/16] firmware: qcom: Add a generic PAS service Sumit Garg
2026-05-05 17:32 ` Mukesh Ojha
2026-05-04 13:05 ` [PATCH v5 03/16] firmware: qcom_scm: Migrate to " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 04/16] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-05-04 13:05 ` [PATCH v5 05/16] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-05-04 13:05 ` [PATCH v5 06/16] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 07/16] soc: qcom: mdtloader: " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 08/16] remoteproc: qcom_wcnss: " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 09/16] remoteproc: qcom: Select QCOM_PAS generic service Sumit Garg
2026-05-04 13:05 ` [PATCH v5 10/16] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-05-04 13:05 ` [PATCH v5 11/16] media: qcom: " Sumit Garg
2026-05-04 13:05 ` [PATCH v5 12/16] media: qcom: Pass proper PAS ID to set_remote_state API Sumit Garg
2026-05-04 13:06 ` [PATCH v5 13/16] net: ipa: Switch to generic PAS TZ APIs Sumit Garg
2026-05-04 13:06 ` [PATCH v5 14/16] wifi: ath12k: " Sumit Garg
2026-05-05 14:27 ` Jeff Johnson
2026-05-05 14:50 ` Jeff Johnson [this message]
2026-05-04 13:06 ` [PATCH v5 15/16] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-05-04 13:06 ` [PATCH v5 16/16] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae68bdb3-d683-4e7a-a27f-739214656ce2@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=apurupa@qti.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jens.wiklander@linaro.org \
--cc=jesszhan0024@gmail.com \
--cc=jjohnson@kernel.org \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=pabeni@redhat.com \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=skare@qti.qualcomm.com \
--cc=sowmiya.elavalagan@oss.qualcomm.com \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=sumit.garg@kernel.org \
--cc=sumit.garg@oss.qualcomm.com \
--cc=tonyh@qti.qualcomm.com \
--cc=trilokkumar.soni@oss.qualcomm.com \
--cc=vignesh.viswanathan@oss.qualcomm.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox