From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4D58CD3424 for ; Fri, 1 May 2026 13:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q4oDi7RWtV5ujgVIPlsjabJH9G4nIV19RkuEx7asbLU=; b=fulLYphfbm+IDbQz5t9wOaC8N3 zypyAkQsLHhyYV9kBTX2FeHk33QV5rDc27mBxPsESO/u/xVUrr4GqcdYxXBtKENWojMOejVGAQzmY UKscvuxmTtdYgJ/zNBU+kVuEISIdsgOYxS+/hgXNprAxG2eCMjuleU9CwLiSGAsFMQEyyKOjbICiZ GkfS8VnU/drpY5mUwsy1V0Y2gimHh2uZctK41NGmjk7sDGUad3J58aDxstJiUs1xjL+aij5zNvx+B LAxK7/Hb4rf0AxKEzxZIo5c2m3/DzIuTcuAFFdzjFJJUh4d8XFZIEVDIcQREl4nCLO1NlGIdoan6y aoEedZzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wIoOa-00000007Cck-24SG; Fri, 01 May 2026 13:59:08 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wIoOY-00000007Ccb-2GdP for ath12k@lists.infradead.org; Fri, 01 May 2026 13:59:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 980CE600AE; Fri, 1 May 2026 13:59:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A28EC2BCB4; Fri, 1 May 2026 13:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777643945; bh=pyGGj8CgYj8YKM+1n+ffgeaGs4n29YMxEkBJUo1PKMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BIohrFybibBQ29JXyaKkk7tpR9SY33a1ULDEXYO0ggJZPVBGjV4kol4a3Oo5KcigC vvl9rtpktZmkYOvK0ZanKn5pBn6I40+FNXlG6+Q0fDXt4fhrSahOTWeDeIRNvDgAnr qDfcMkpOLtgmvARVrNbe0mo8GqgtIXcSiA9pijs0QRaex7NWmA3+rEhaS4Lf7PSUmf l21wV01YBfLy+sLbcNH30NUp0eRR29R3odnhq/LXGzgCEJ5UkDgZxxIFufJWtzHLv8 9lpiqvzMaJU41PHE5LzQZ5BOt4WzIJJADN2rcjfT6oC6zaFI9Mexu3hhwSvCsrIBBx Wbtz6RzKcrZGA== Date: Fri, 1 May 2026 19:28:48 +0530 From: Sumit Garg To: Mukesh Ojha Cc: andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH v4 06/15] remoteproc: qcom_q6v5_mss: Switch to generic PAS TZ APIs Message-ID: References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-7-sumit.garg@kernel.org> <20260429133157.lopr6n5vaik36466@hu-mojha-hyd.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429133157.lopr6n5vaik36466@hu-mojha-hyd.qualcomm.com> X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2026 at 07:01:57PM +0530, Mukesh Ojha wrote: > On Mon, Apr 27, 2026 at 03:25:54PM +0530, Sumit Garg wrote: > > From: Sumit Garg > > > > Switch qcom_q6v5_mss client driver over to generic PAS TZ APIs. Generic PAS > > TZ service allows to support multiple TZ implementation backends like QTEE > > based SCM PAS service, OP-TEE based PAS service and any further future TZ > > backend service. > > > > Signed-off-by: Sumit Garg > > --- > > drivers/remoteproc/qcom_q6v5_mss.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > > index ae78f5c7c1b6..96888007faa8 100644 > > --- a/drivers/remoteproc/qcom_q6v5_mss.c > > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > > @@ -34,6 +34,7 @@ > > #include "qcom_pil_info.h" > > #include "qcom_q6v5.h" > > > > +#include > > #include > > same here., whether it is needed now ? Ditto, needed for qcom_scm_assign_mem(). > > > > > #define MPSS_CRASH_REASON_SMEM 421 > > @@ -1480,7 +1481,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) > > } > > > > if (qproc->need_pas_mem_setup) { > > - ret = qcom_scm_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size); > > + ret = qcom_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size); > > if (ret) { > > dev_err(qproc->dev, > > "setting up mpss memory failed: %d\n", ret); > > @@ -2077,7 +2078,7 @@ static int q6v5_probe(struct platform_device *pdev) > > if (!desc) > > return -EINVAL; > > > > - if (desc->need_mem_protection && !qcom_scm_is_available()) > > + if (desc->need_mem_protection && !qcom_pas_is_available()) > > return -EPROBE_DEFER; > > > > mba_image = desc->hexagon_mba_image; > > Reviewed-by: Mukesh Ojha Thanks. -Sumit