From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FD1DFF885A for ; Mon, 4 May 2026 11:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+eZlhmZBq6FFrJhX9KsoG56fYe01qFHr71NxDR7aQzQ=; b=D1hsNZauIgue4Osecuns0+7X4a T6rP4wAiha7r1sxJZy9PpbgTAas9WcRbIQI9PT3OklE2TcSBEg/1f3hO6N9OLKM6GqZ56eFuYqZsI pOxd2pp+LLGJ8b+cYy5wCsIKmNzSBCqGf21rDE9cyjbEPgcvvFKs7eBFH6iCjMPvZqiEbRe23obbh S0cX1EkjCIsaCNPqgJV7BuzPXVZYfNoiuBJppkrolMcvs71ApSeY5fS9NFqM9nhtS8hkvkm5qXqHS 2dFSwVEai38fLhQm5M/68m/Ix4XKZqDrflgXCfiHmra222fxQzMi34mjxFaaXath+ONA3VLhiDz09 soeM85Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wJrOu-0000000D28i-12l5; Mon, 04 May 2026 11:23:48 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wJrOr-0000000D28E-1oaV for ath12k@lists.infradead.org; Mon, 04 May 2026 11:23:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1F2A043DA9; Mon, 4 May 2026 11:23:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17416C2BCB8; Mon, 4 May 2026 11:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777893824; bh=1w+MzSobxxhh4/Z6BnF1Kps4Ui5Z89S5baW8VF7cW6E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bKjpZmuvT3AASZNwdOzNxp2knijQMyMENFMHM5uqAOrV+70C3W/V+G62NSkeLnjzL d7IH3uPHFHyq6SvUwEUCu6X33eAaaVpuGEI+NWlgvBQgKDyKKsXmUsMFbxJTZk5XmB Lo3jNju8AYgqS3cynz2WeFDWRkxL7rvgwSY5jsqgL9E7bn8S4dT+McwB5oeSR6cyY8 GE5Y1kovSElzmwnbUck5r3saI9Xt0dB57LfWOdOonvUwnNHfNwZ0RJwogibRCtfsn8 L4L0/hTuWlEatyhi8lNXCX9h5krZSukJ7LkRsewUB1J58/zkoNMLAc9tK7EMOodhSX SWLdQcNbZAOaQ== Date: Mon, 4 May 2026 16:53:26 +0530 From: Sumit Garg To: Mukesh Ojha Cc: andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH v4 03/15] firmware: qcom_scm: Migrate to generic PAS service Message-ID: References: <20260427095603.1157963-1-sumit.garg@kernel.org> <20260427095603.1157963-4-sumit.garg@kernel.org> <20260429104841.l555xd2izoyrqjp4@hu-mojha-hyd.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260504_042345_550878_462378BF X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On Fri, May 01, 2026 at 07:11:19PM +0530, Sumit Garg wrote: > On Wed, Apr 29, 2026 at 04:18:41PM +0530, Mukesh Ojha wrote: > > On Mon, Apr 27, 2026 at 03:25:51PM +0530, Sumit Garg wrote: > > > From: Sumit Garg > > > > > > With the availability of generic PAS service, let's add SCM calls as > > > a backend to keep supporting legacy QTEE interfaces. The exported > > > qcom_scm* wrappers will get dropped once all the client drivers get > > > migrated as part of future patches. > > > > > > Signed-off-by: Sumit Garg > > > --- > > > drivers/firmware/qcom/Kconfig | 1 + > > > drivers/firmware/qcom/qcom_scm.c | 335 ++++++++++++++----------------- > > > 2 files changed, 155 insertions(+), 181 deletions(-) > > > > > > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > > > index 9b06a69d3a6d..d87a962e93da 100644 > > > --- a/drivers/firmware/qcom/qcom_scm.c > > > +++ b/drivers/firmware/qcom/qcom_scm.c > > > > > > -/** > > > - * qcom_scm_pas_shutdown() - Shut down the remote processor > > > - * @pas_id: peripheral authentication service id > > > - * > > > - * Returns 0 on success. > > > - */ > > > -int qcom_scm_pas_shutdown(u32 pas_id) > > > +static int __qcom_scm_pas_set_remote_state(struct device *dev, u32 state, > > > + u32 pas_id) > > > +{ > > > + struct qcom_scm_desc desc = { > > > + .svc = QCOM_SCM_SVC_BOOT, > > > + .cmd = QCOM_SCM_BOOT_SET_REMOTE_STATE, > > > + .arginfo = QCOM_SCM_ARGS(2), > > > + .args[0] = state, > > > + .args[1] = pas_id, > > > + .owner = ARM_SMCCC_OWNER_SIP, > > > + }; > > > + struct qcom_scm_res res; > > > + int ret; > > > + > > > + ret = qcom_scm_call(dev, &desc, &res); > > > + > > > + return ret ? : res.result[0]; > > > +} > > > + > > > +int qcom_scm_set_remote_state(u32 state, u32 id) > > > > s/id/pas_id > > Ack. > Coming back to this comment again, since this is a temporary wrapper which is going to be dropped as part of 2nd last patch, I don't think there is value to fix them as they maintain existing APIs interface. -Sumit