From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A826C44501 for ; Wed, 1 Jul 2026 12:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VEtKY19/199sq5hBEK8vvyifwBLgNYHuvPBHa8OeONM=; b=WBwKQOpnE2gZ9xFe3LraDlH5qN J6IPwBcD80Ygpe80IlHMx9tzRNwmjThg/VpfqHTUJdDmoMxF6hxoGWugboRLrQKq9vMQFMgRr2W6S 3Z7p7SwCyLCykPuFI5OQ5lDGgeEo/3yZ/XFIdzmzWPUtJ6HfNCPn8gfm0Xs4m7OxXlHdMBtb6mAwJ FBx3vYi2b9dbdJYSR5o9Dg8FrJx5X9iSmMh454z5j8pyp7o4xqtmEfDmw87te4yNQm3//B12Q4UJI EdTGMk4drDFL0zFe1Gi4LANu9g5l0X0Cr9NGGIvjO6Yu/gPH0D2IS9gC/6X7cYkcgyQwyep64HOJn B+F30pRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wetuy-00000001pw3-0sPX; Wed, 01 Jul 2026 12:19:52 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wetuw-00000001pqj-16D6 for ath12k@lists.infradead.org; Wed, 01 Jul 2026 12:19:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A5B2341E8B; Wed, 1 Jul 2026 12:19:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A7A51F00A3A; Wed, 1 Jul 2026 12:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782908389; bh=VEtKY19/199sq5hBEK8vvyifwBLgNYHuvPBHa8OeONM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jtFKcyyZbtAmVVr+fjAxI0mN12qeBbZGTuUw9k9BXdiEiT6bA/LMEPDeHMMdvoAvt kXrgEn+QCk7kmuFJLiy8pfRdMmQE1MM0azpxyJhvk+ND3rXxhq37jO/aS/w3DkRAYB Yqib/iB/7fYJ/QRLpHsQqhAum5lS8ZiA39ewOynpW1hfKl/peb/UheJYM1BKEBR+zF KbgWdMRPPFSJ6dUqpLNUfnsNm9MdiQxnS/H+zUrOSwoQW/+ddPaWE2+IKllaKJ2jTL Pt79dgBU+Vjv+rcT/UjKjLAhEg30YCwfroYzWb5zRrtHvvm0jvgAmjc3XY0LBR0w68 M6TAGF0pGPmYw== Date: Wed, 1 Jul 2026 17:49:32 +0530 From: Sumit Garg To: Konrad Dybcio Cc: andersson@kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH v8 10/14] media: qcom: Pass proper PAS ID to set_remote_state API Message-ID: References: <20260626133440.692849-1-sumit.garg@kernel.org> <20260626133440.692849-11-sumit.garg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2026 at 01:01:52PM +0200, Konrad Dybcio wrote: > On 7/1/26 9:44 AM, Sumit Garg wrote: > > On Tue, Jun 30, 2026 at 02:42:25PM +0200, Konrad Dybcio wrote: > >> On 6/26/26 3:34 PM, Sumit Garg wrote: > >>> From: Sumit Garg > >>> > >>> As per testing the SCM backend just ignores it while OP-TEE makes > >>> use of it to for proper book keeping purpose. > >>> > >>> Reviewed-by: Mukesh Ojha > >>> Tested-by: Mukesh Ojha # Lemans > >>> Reviewed-by: Vikash Garodia > >>> Signed-off-by: Sumit Garg > >>> --- > >>> drivers/media/platform/qcom/iris/iris_firmware.c | 2 +- > >>> drivers/media/platform/qcom/venus/firmware.c | 2 +- > >>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > >>> index ea9654dd679e..d2e7ba4f37e3 100644 > >>> --- a/drivers/media/platform/qcom/iris/iris_firmware.c > >>> +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > >>> @@ -110,5 +110,5 @@ int iris_fw_unload(struct iris_core *core) > >>> > >>> int iris_set_hw_state(struct iris_core *core, bool resume) > >>> { > >>> - return qcom_pas_set_remote_state(resume, 0); > >>> + return qcom_pas_set_remote_state(resume, IRIS_PAS_ID); > >>> } > >>> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > >>> index 3a38ff985822..3c0727ea137d 100644 > >>> --- a/drivers/media/platform/qcom/venus/firmware.c > >>> +++ b/drivers/media/platform/qcom/venus/firmware.c > >>> @@ -59,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) > >>> int ret; > >>> > >>> if (core->use_tz) { > >>> - ret = qcom_pas_set_remote_state(resume, 0); > >>> + ret = qcom_pas_set_remote_state(resume, VENUS_PAS_ID); > >> > >> This should not be in the middle of a mildly related series.. > >> The PAS IDs should be centralized into a single header. And the > >> name of the driver shouldn't be part of the define. I would guesstimate > >> that on the secure side it's probably called VPU or VIDEO > > > > I agree with your comments, this is something I would also like to > > consolidate on OP-TEE side as well: see discussion here [1]. > > > > However, the patch itself was needed to do book keeping on OP-TEE side > > but I can drop it since anyhow the video isn't functional yet in > > upstream dependent on the proper IOMMU support. > > For this patch.. I think QCTZ may be ignoring the argument so it > may not matter.. on a second thought you already have it reviewed > and it's already a cross-subsys merge so might as well pull it in, > worst case scenario it'll revert cleanly Thanks, I will keep it then. > > Once this lands, please move all PAS defines to.. hmm.. qcom_pas.h > sounds like a good candidate? Sure, I will propose that as a follow-up change. We have to agree on common naming there. -Sumit