From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>,
Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Avula Sri Charan <quic_asrichar@quicinc.com>
Subject: Re: [PATCHv2] wifi: ath12k: Avoid napi_sync before napi_enable
Date: Thu, 30 Jan 2025 07:05:57 -0800 [thread overview]
Message-ID: <b155f782-feea-4b99-8edd-e499e313294e@oss.qualcomm.com> (raw)
In-Reply-To: <dd37c366-21f5-470b-9d4c-24ae2808c4bd@oss.qualcomm.com>
On 1/24/2025 8:55 PM, Aditya Kumar Singh wrote:
> On 1/24/25 14:30, Tamizh Chelvam Raja wrote:
>> From: Avula Sri Charan <quic_asrichar@quicinc.com>
>>
>> In case of MHI error a reset work will be queued
>> which will try napi_disable after napi_synchronize.
>
> nit: always better to refer function name with () at end. I guess Jeff
> can fix in pending?
I fixed this, as well as did some other grammar & formatting fixes.
Please check:
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=a644c8784220b7d5dd0a10a45c5e6779605778a5
>
>>
>> As the napi will be only enabled after qmi_firmware_ready
>> event trying napi_synchronize before napi_enable will
>> result in indefinite sleep in case of a firmware crash
>> in QMI init sequence.
>>
>> To avoid this introduce napi_enabled flag to check
>> if napi is enabled or not before calling napi_synchronize.
>>
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Avula Sri Charan <quic_asrichar@quicinc.com>
>> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
>> ---
>
> Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
>
next prev parent reply other threads:[~2025-01-30 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 9:00 [PATCHv2] wifi: ath12k: Avoid napi_sync before napi_enable Tamizh Chelvam Raja
2025-01-25 4:55 ` Aditya Kumar Singh
2025-01-30 15:05 ` Jeff Johnson [this message]
2025-01-30 16:54 ` Aditya Kumar Singh
2025-02-03 22:49 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b155f782-feea-4b99-8edd-e499e313294e@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_asrichar@quicinc.com \
--cc=quic_tamizhr@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox