From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Ripan Deuri <quic_rdeuri@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath12k-ng 1/2] wifi: ath12k: Refactor data path pdev struct
Date: Wed, 1 Oct 2025 09:32:26 -0700 [thread overview]
Message-ID: <b3c4ab9c-317c-4b68-b00a-d91c1d47b0d6@oss.qualcomm.com> (raw)
In-Reply-To: <20250930181848.3386271-2-quic_rdeuri@quicinc.com>
On 9/30/2025 11:18 AM, Ripan Deuri wrote:
> diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
> index 1bca998117b7..98af9a17dea2 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.c
> +++ b/drivers/net/wireless/ath/ath12k/dp.c
...> +struct ath12k *ath12k_pdev_dp_to_ar(struct ath12k_pdev_dp *dp)
> +{
> + return container_of(dp, struct ath12k, dp);
> +}
> diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
> index 546f73e46c41..084e0a3c1bbb 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.h
> +++ b/drivers/net/wireless/ath/ath12k/dp.h
...> +struct ath12k *ath12k_pdev_dp_to_ar(struct ath12k_pdev_dp *dp);
is there a reason this isn't a static inline?
the implementation is trivial and this seems like an example where inlining
would always produce a "better" executable.
/jeff
next prev parent reply other threads:[~2025-10-01 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 18:18 [PATCH ath12k-ng 0/2] wifi: ath12k: Modularization of PDEV object for Next Generation Driver Ripan Deuri
2025-09-30 18:18 ` [PATCH ath12k-ng 1/2] wifi: ath12k: Refactor data path pdev struct Ripan Deuri
2025-10-01 16:32 ` Jeff Johnson [this message]
2025-10-07 10:51 ` Ripan Deuri
2025-09-30 18:18 ` [PATCH ath12k-ng 2/2] wifi: ath12k: Rearrange PPDU radio stats Ripan Deuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c4ab9c-317c-4b68-b00a-d91c1d47b0d6@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rdeuri@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox